Fix broken icon paths - #52
Open
Kota-Jagadeesh wants to merge 1 commit into
Open
Conversation
|
@Kota-Jagadeesh is attempting to deploy a commit to the amFOSS Dev Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes social icon images failing to load on deep routes (e.g., individual member pages) after a reload by replacing relative icon asset paths with root-absolute paths, matching how other public assets are referenced in the Next.js app.
Changes:
- Updated social icon
imageentries incontent/socials.jsonfrom./assets/...to/assets/...so they resolve correctly regardless of the current route.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rn in the website, when navigating to an individual member page (e.g., https://amfoss.in/team/k-k-surendran) and reloading it, the icons fail to load correctly. The issue was caused by broken relative asset paths. Fixed by switching to absolute asset paths so that icons render properly on reload.