fix(android): cover never appears on Samsung One UI (BadTokenException on host walk)

Reported on Samsung Galaxy A05 (SM-A057F) running Android 14 with One UI:
pressing Home left the Recents thumbnail showing the underlying React Native
UI instead of the configured privacy cover. Logcat from the affected device:

  Cover : ensureCoverOnTopmost: reparent (topmost=FreezableFrameLayout)
                                                  ^^^^^^^^^^^^^^^^^^^^
  Cover : attachCover: addView failed:
          android.view.WindowManager$BadTokenException:
          Unable to add window -- token android.view.ViewRootImpl$W@d70be2d
          is not valid; is your activity running?

The host-window walk (`CoverWindowAttachment.topmostHostViewFor`) excluded
`coverView` (the cover Window's root — `SurfaceView` on the SCVH path,
`FrameLayout` on legacy) but not `coverContent` (the SCVH-hosted
`FreezableFrameLayout`). On Samsung One UI's customised WindowManager the
SCVH-hosted content appears in `WindowManagerGlobal.mViews` even though it
lives inside the SCVH's own `ViewRootImpl`. The walk found our own content
view as the "topmost host", `addCover` tried to attach the cover as a
sub-window of itself, and `addView` rejected the token. The cover never
reached the Recents thumbnail.

Fix: pass `exclude2 = coverContent` at all three `topmostHostViewFor`
callsites in `HybridCover.kt`. `CoverWindowAttachment` already supported
the parameter (the blur source picker uses it for the same reason on the
SCVH path).

Verified on Samsung Galaxy A05 (Android 14, One UI):

  Cover : ensureCoverOnTopmost: reparent (topmost=DecorView)
  Cover : attachCover: preferredRefreshRate=90.0
  Cover : broadcast: reason=homekey isEnabled=true isVisible=false sc=false
  Cover : broadcast: fast scvh=false refl=false dt=1ms
  Cover : performUserLeaveMount
  Cover : setCoverVisibility: visible=true animated=false scvh=false

Recents thumbnail shows the #5F8AFA splash background with the icon, exactly
the iOS App Switcher parity the library was designed to deliver.

Author: amillez

android/src/main/java/com/margelo/nitro/cover/HybridCover.kt

@@ -564,7 +564,22 @@ class HybridCover : HybridCoverSpec() {
     val decor = activity.window?.decorView ?: return
     if (decor.windowToken == null) return
 
-    val topmost = CoverWindowAttachment.topmostHostViewFor(activity, exclude = coverView) ?: decor
+    // Exclude both the cover Window's root (`coverView` — SurfaceView
+    // on SCVH path, FrameLayout on legacy) AND the SCVH-hosted content
+    // (`coverContent`). On some OEM builds (Samsung One UI on Android
+    // 14, observed on the Galaxy A05 / SM-A057F) the SCVH's content
+    // view appears in `WindowManagerGlobal.mViews` even though it
+    // lives inside the SCVH's own ViewRootImpl. Without excluding it
+    // the host walk picks our own content view as the "topmost", we
+    // then try to attach the cover as a sub-window of itself, and
+    // `addView` throws `BadTokenException: Unable to add window —
+    // token … is not valid; is your activity running?`. The cover
+    // never appears in the Recents thumbnail on those devices.
+    val topmost = CoverWindowAttachment.topmostHostViewFor(
+      activity,
+      exclude = coverView,
+      exclude2 = coverContent,
+    ) ?: decor
     val targetToken = topmost.windowToken ?: decor.windowToken!!
 
     val current = coverView
@@ -639,7 +654,22 @@ class HybridCover : HybridCoverSpec() {
     // live: while a Dialog is in front, the activity decor's window
     // never sees the focus regain that signals "user came back via
     // Recents tap" — but the Dialog's decor does.
-    val topmost = CoverWindowAttachment.topmostHostViewFor(activity, exclude = coverView) ?: decor
+    // Exclude both the cover Window's root (`coverView` — SurfaceView
+    // on SCVH path, FrameLayout on legacy) AND the SCVH-hosted content
+    // (`coverContent`). On some OEM builds (Samsung One UI on Android
+    // 14, observed on the Galaxy A05 / SM-A057F) the SCVH's content
+    // view appears in `WindowManagerGlobal.mViews` even though it
+    // lives inside the SCVH's own ViewRootImpl. Without excluding it
+    // the host walk picks our own content view as the "topmost", we
+    // then try to attach the cover as a sub-window of itself, and
+    // `addView` throws `BadTokenException: Unable to add window —
+    // token … is not valid; is your activity running?`. The cover
+    // never appears in the Recents thumbnail on those devices.
+    val topmost = CoverWindowAttachment.topmostHostViewFor(
+      activity,
+      exclude = coverView,
+      exclude2 = coverContent,
+    ) ?: decor
     val targetToken = topmost.windowToken ?: decor.windowToken!!
 
     if (coverView != null && coverAttachedToken === targetToken
@@ -1740,7 +1770,22 @@ class HybridCover : HybridCoverSpec() {
     // destroyed (e.g. a Modal that the cover was attached to has
     // since dismissed), in which case re-attaching to the stale
     // token would throw and silently leave the cover unmounted.
-    val topmost = CoverWindowAttachment.topmostHostViewFor(activity, exclude = coverView) ?: decor
+    // Exclude both the cover Window's root (`coverView` — SurfaceView
+    // on SCVH path, FrameLayout on legacy) AND the SCVH-hosted content
+    // (`coverContent`). On some OEM builds (Samsung One UI on Android
+    // 14, observed on the Galaxy A05 / SM-A057F) the SCVH's content
+    // view appears in `WindowManagerGlobal.mViews` even though it
+    // lives inside the SCVH's own ViewRootImpl. Without excluding it
+    // the host walk picks our own content view as the "topmost", we
+    // then try to attach the cover as a sub-window of itself, and
+    // `addView` throws `BadTokenException: Unable to add window —
+    // token … is not valid; is your activity running?`. The cover
+    // never appears in the Recents thumbnail on those devices.
+    val topmost = CoverWindowAttachment.topmostHostViewFor(
+      activity,
+      exclude = coverView,
+      exclude2 = coverContent,
+    ) ?: decor
     val targetToken = topmost.windowToken ?: decor.windowToken ?: return
     attachCover(activity, targetToken = targetToken, visible = isVisible, animated = false)
   }