Conversation
iio_block_dequeue() only returns 0 on success for the local backend. Over the network/serial/USB iiod-client backend, a successful dequeue returns the number of bytes transferred, which is a positive, non-zero value. Checking `if (ret)` treated every successful network RX dequeue as an error, tearing down the buffer and throwing on the very first getSamples() call. Check `ret < 0` instead, matching how iiod_client_dequeue_block() actually reports success/failure. Signed-off-by: Marius Lucacel <marius.lucacel@analog.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iio_block_dequeue() only returns 0 on success for the local backend. Over the network/serial/USB iiod-client backend, a successful dequeue returns the number of bytes transferred, which is a positive, non-zero value.
Checking
if (ret)treated every successful network RX dequeue as an error, tearing down the buffer and throwing on the very first getSamples() call.Check
ret < 0instead, matching how iiod_client_dequeue_block() actually reports success/failure.