Repository navigation
Keep user preferences out of config API subscriptions - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subscription responses previously included routeAllApps=true and other application defaults, which could overwrite locally configured split tunneling and preferences when imported or refreshed.
Limit API responses to profiles, connection parameters, credential inclusion flags and subscription endpoints/bootstrap settings. Omit root/profile routing, DNS, SSH tuning, failover, active/always-on selection, diagnostic limits and browser preferences, including explicit inventory overrides. Preserve explicit TLS/JA3 and technical browser fields (knockHost, authMode, masqueTemplate). A null subscription override no longer removes subscription endpoints. File exports retain their existing behavior.
Validation: 86 tests passed (test_config_api.py and test_inventory.py), Ruff and git diff --check passed. Already deployed to config_ru and config_kz with no Ansible failures; authenticated HTTPS responses checked on both hosts for generic, Android, Firefox and Chromium clients.
Client-side preservation of omitted settings still needs verification in the application.