Skip to content

[domain] force message priority serialization - #109

Merged
capcom6 merged 2 commits into
masterfrom
domain/force-message-priority
Sep 23, 2026
Merged

capcom6 merged 2 commits into
masterfrom
domain/force-message-priority

Conversation

@capcom6

@capcom6 capcom6 commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Serialized messages now consistently include a priority value, defaulting to 0 when none is configured.
    • Improved compatibility for consumers relying on a consistent message format.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3b056609-1e57-4193-b605-79523a1a94bc

📥 Commits

Reviewing files that changed from the base of the PR and between 1007041 and 5524a90.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • README.md
  • src/Domain/Message.php
  • tests/Domain/MessageTest.php

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 81ab7de2-36aa-4b98-ba94-455474005215

📥 Commits

Reviewing files that changed from the base of the PR and between 7be36d2 and 1007041.

📒 Files selected for processing (2)
  • src/Domain/Message.php
  • tests/Domain/MessageTest.php

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Message::ToObject() now always serializes priority, using 0 when no value is configured. Tests verify the default in object serialization and JSON output.

Changes

Message serialization

Layer / File(s) Summary
Priority serialization and validation
src/Domain/Message.php, tests/Domain/MessageTest.php
Message::ToObject() now assigns priority as the configured value or 0. Tests verify the serialized object and default JSON output.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 10070

The change adds the default priority to serialized messages with matching coverage, and no concrete merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: always serializing message priority.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@capcom6

capcom6 commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@capcom6
capcom6 force-pushed the domain/force-message-priority branch from 1007041 to 8177ddf Compare September 22, 2026 02:04
@capcom6
capcom6 merged commit 2aa9667 into master Sep 23, 2026
6 checks passed
@capcom6
capcom6 deleted the domain/force-message-priority branch September 23, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant