Repository navigation
Improve booking server and Firebase integration - #189
Conversation
…nager - Adds A2uiSchemaManager in server/main.py to load booking_catalog.json and generate system prompt - Configures specialized ADK Agents for flights, hotels, activities, and dining with interactive make_update_ui tool - Streams native A2UI protocol events (createSurface, updateComponents) over SSE - Updates BookingAssistantViewModel to parse and render native A2UI protocol payloads directly - Updates server/requirements.txt to include a2ui-agent>=0.9.0 and google-adk>=0.1.0
ksemenova
left a comment
ksemenova
left a comment
There was a problem hiding this comment.
Looks good overall with few minor comments.
For code readability suggesting to replace the low-level JSONObject traversal with typed data classes (e.g., using kotlinx.serialization or a dedicated mapper)
| Log.w("JetPackerApplication", "Firebase not initialized") | ||
| } | ||
| } catch (e: Exception) { | ||
| Log.w("JetPackerApplication", "Firebase initialization error", e) |
There was a problem hiding this comment.
If initialization fails how the app should work? Do we need to exit here?
There was a problem hiding this comment.
Nah the rest of the features will still work so no need to fully cancel. We should just make sure not to crash
| } catch (e: Exception) { | ||
| log("FirebaseAuth.getInstance failed: ${e.message}") | ||
| Log.e("BookingAssistant", "FirebaseAuth.getInstance failed", e) | ||
| return "" |
There was a problem hiding this comment.
why do we return an empty token here? should it return the exception?
There was a problem hiding this comment.
Basically we choose to catch the exception here instead of at the caller site so that we can run the app even when firebase is not initialized and at least test the other features. Not the best user experience as the firebase features would not work, but that's not our demo scenario anyway.
| componentsList.add(A2uiComponentPayload(id = id, type = type, properties = propsMap)) | ||
| } | ||
| } | ||
| val firstComp = componentsList.firstOrNull() |
There was a problem hiding this comment.
why do we process only the first component?
There was a problem hiding this comment.
Currently the backend is written so it only returns the one component, so we should just retrieve that one.
I removed that whole traversal all-together :) |
…side execution - Adds /v2/* routes in openapi.yaml pointing to parallel Cloud Run service jetpacker-server-v2 - Makes OIDC streaming audience dynamic via CLOUD_RUN_AUDIENCE in server/main.py - Uses inspect.signature for dynamic ADK initialization and adds booking/ root agent discovery module - Introduces BackendEndpoint selector (PARALLEL_STAGING, PRODUCTION, LOCAL) in BookingAssistantViewModel defaulting to /v2 - Adds deployment instructions for production and parallel staging backends to README.md
2 participants
No description provided.