Skip to content

Commit 2c17151

Browse files
cpovirkcopybara-androidxtest
authored andcommitted
Remove null check on the result of Class.forName.
The method never returns `null`; it either fails or returns the `Class`. As a result, I am making calls like this into errors in google/error-prone#6093. PiperOrigin-RevId: 989783886
1 parent 92d1b17 commit 2c17151

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

‎ext/junit/java/androidx/test/ext/junit/runners/AndroidJUnit4.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ && hasClass("org.robolectric.RobolectricTestRunner")) {
7171

7272
private static boolean hasClass(String className) {
7373
try {
74-
return Class.forName(className) != null;
74+
Class<?> unused = Class.forName(className);
75+
return true;
7576
} catch (ClassNotFoundException e) {
7677
return false;
7778
}

0 commit comments

Comments
 (0)