Add test coverage, static analysis (Detekt, ktlint), code coverage (Kover), and fix CI

- Add Detekt, ktlint, and Kover to convention plugin for all library modules
- Add unit tests for vbpd-core (LazyViewBindingProperty, EagerViewBindingProperty)
- Add lifecycle tests for vbpd (Activity, Fragment, ViewGroup, ViewHolder)
- Add tests for vbpd-reflection (ViewBindingCache, CreateMethod)
- Fix minor code style issues (double spaces, extra blank lines)
- Update CI pipelines: remove continue-on-error, add test/lint/coverage steps
- Add Detekt configuration file (config/detekt/detekt.yml)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: kirich1409

.github/workflows/android.yml

@@ -1,4 +1,4 @@
-name: Android quality checks
+name: Quality Checks
 
 on:
   push:
@@ -8,12 +8,12 @@ on:
 
 jobs:
   check:
-
     runs-on: ubuntu-latest
 
     steps:
     - uses: actions/checkout@v4
-    - name: set up JDK
+
+    - name: Set up JDK
       uses: actions/setup-java@v4
       with:
         java-version: '21'
@@ -22,19 +22,26 @@ jobs:
 
     - name: Grant execute permission for gradlew
       run: chmod +x gradlew
-    
-    - name: Check build
+
+    - name: Run all checks
       run: ./gradlew check
-      continue-on-error: true
-    
-    - name: Save Gradle cache
-      uses: actions/cache@v4
-      continue-on-error: true
+
+    - name: Generate coverage report
+      run: ./gradlew koverXmlReport
+
+    - name: Upload test results
+      if: always()
+      uses: actions/upload-artifact@v4
+      with:
+        name: test-results
+        path: |
+          **/build/test-results/
+          **/build/reports/tests/
+
+    - name: Upload coverage reports
+      if: always()
+      uses: actions/upload-artifact@v4
       with:
+        name: coverage-reports
         path: |
-          ~/.gradle/caches
-          ~/.gradle/wrapper
-        key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
-        restore-keys: |
-          ${{ runner.os }}-gradle-
-          
+          **/build/reports/kover/

.github/workflows/build.yml

@@ -1,4 +1,4 @@
-name: Build libs
+name: Build & Test
 
 on:
   push:
@@ -7,12 +7,12 @@ on:
 
 jobs:
   check:
-
     runs-on: ubuntu-latest
 
     steps:
     - uses: actions/checkout@v4
-    - name: set up JDK
+
+    - name: Set up JDK
       uses: actions/setup-java@v4
       with:
         java-version: '21'
@@ -21,28 +21,41 @@ jobs:
 
     - name: Grant execute permission for gradlew
       run: chmod +x gradlew
-    
-    - name: Check build
+
+    - name: Build libraries
       run: ./gradlew :vbpd-core:assembleRelease :vbpd:assembleRelease :vbpd-reflection:assembleRelease
-      continue-on-error: true
-    
-    - name: Save Gradle cache
-      uses: actions/cache@v4
-      continue-on-error: true
+
+    - name: Run tests
+      run: ./gradlew testDebugUnitTest
+
+    - name: Run code quality checks
+      run: ./gradlew detekt ktlintCheck
+
+    - name: Generate coverage report
+      run: ./gradlew koverXmlReport
+
+    - name: Upload test results
+      if: always()
+      uses: actions/upload-artifact@v4
       with:
+        name: test-results
         path: |
-          ~/.gradle/caches
-          ~/.gradle/wrapper
-        key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
-        restore-keys: |
-          ${{ runner.os }}-gradle-
+          **/build/test-results/
+          **/build/reports/tests/
 
-    - name: Save build artifacts
+    - name: Upload coverage reports
+      if: always()
+      uses: actions/upload-artifact@v4
+      with:
+        name: coverage-reports
+        path: |
+          **/build/reports/kover/
+
+    - name: Upload build artifacts
       uses: actions/upload-artifact@v4
       with:
         name: vbpd-libs-builds
-        path: 
-          vbpd/build/outputs/aar/*.aar
+        path: |
           vbpd-core/build/outputs/aar/*.aar
+          vbpd/build/outputs/aar/*.aar
           vbpd-reflection/build/outputs/aar/*.aar
-          

config/detekt/detekt.yml

@@ -0,0 +1,29 @@
+build:
+  maxIssues: 0
+
+complexity:
+  LongMethod:
+    threshold: 60
+  LongParameterList:
+    functionThreshold: 8
+    constructorThreshold: 8
+  TooManyFunctions:
+    thresholdInFiles: 20
+    thresholdInClasses: 15
+    thresholdInInterfaces: 10
+
+style:
+  MaxLineLength:
+    maxLineLength: 120
+  WildcardImport:
+    active: false
+  MagicNumber:
+    active: false
+  ReturnCount:
+    max: 3
+  UnusedPrivateMember:
+    active: true
+
+naming:
+  FunctionNaming:
+    functionPattern: '[a-zA-Z][a-zA-Z0-9]*'

gradle/convetions-plugins/vbpd-library-base/build.gradle.kts

@@ -9,6 +9,9 @@ dependencies {
     implementation(libs.gradleplugins.android)
     implementation(libs.gradleplugins.kotlin)
     implementation(libs.gradleplugins.vanniktechMavenPublish)
+    implementation(libs.gradleplugins.detekt)
+    implementation(libs.gradleplugins.ktlint)
+    implementation(libs.gradleplugins.kover)
 
     // Workaround for version catalog working inside precompiled scripts
     // Issue - https://github.com/gradle/gradle/issues/15383

gradle/convetions-plugins/vbpd-library-base/src/main/kotlin/vbpdconfig.gradle.kts

@@ -11,6 +11,9 @@ plugins.apply(libs.plugins.android.library.get().pluginId)
 plugins.apply("maven-publish")
 plugins.apply(libs.plugins.vanniktechMavenPublish.get().pluginId)
 plugins.apply("vbpdpublish")
+plugins.apply(libs.plugins.detekt.get().pluginId)
+plugins.apply(libs.plugins.ktlint.get().pluginId)
+plugins.apply(libs.plugins.kover.get().pluginId)
 
 val libraryId = "${project.group}.${project.name.replace("vbpd-", "").replace("-", ".")}"
 
@@ -43,9 +46,21 @@ androidLibraryConfig {
         jvmTarget = libs.versions.jvmTarget.get()
         freeCompilerArgs += listOf("-module-name", libraryId)
     }
+
+    testOptions {
+        unitTests {
+            isIncludeAndroidResources = true
+        }
+    }
 }
 
 kotlinConfig {
     jvmToolchain(libs.versions.jvmTarget.get().toInt())
     explicitApi()
 }
+
+extensions.configure<io.gitlab.arturbosch.detekt.extensions.DetektExtension> {
+    config.setFrom(rootProject.files("config/detekt/detekt.yml"))
+    buildUponDefaultConfig = true
+    parallel = true
+}

gradle/libs.versions.toml

@@ -14,6 +14,14 @@ kotlin = "2.1.10"
 vanniktechMavenPublish = "0.30.0"
 jvmTarget = "11"
 vbpd = "2.0.4"
+detekt = "1.23.8"
+ktlint = "14.0.1"
+kover = "0.9.7"
+robolectric = "4.16.1"
+mockk = "1.14.9"
+androidx-test-core = "1.6.1"
+androidx-test-runner = "1.6.2"
+junit = "4.13.2"
 
 [libraries]
 androidx-activity = { module = "androidx.activity:activity", version.ref = "androidx-activity" }
@@ -27,10 +35,24 @@ androidx-viewbinding = { module = "androidx.databinding:viewbinding", version.re
 gradleplugins-android = { module = "com.android.tools.build:gradle", version.ref = "agp" }
 gradleplugins-kotlin = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" }
 gradleplugins-vanniktechMavenPublish = { module = "com.vanniktech.maven.publish:com.vanniktech.maven.publish.gradle.plugin", version.ref = "vanniktechMavenPublish" }
+gradleplugins-detekt = { module = "io.gitlab.arturbosch.detekt:detekt-gradle-plugin", version.ref = "detekt" }
+gradleplugins-ktlint = { module = "org.jlleitschuh.gradle:ktlint-gradle", version.ref = "ktlint" }
+gradleplugins-kover = { module = "org.jetbrains.kotlinx:kover-gradle-plugin", version.ref = "kover" }
+
+test-robolectric = { module = "org.robolectric:robolectric", version.ref = "robolectric" }
+test-mockk = { module = "io.mockk:mockk", version.ref = "mockk" }
+test-junit = { module = "junit:junit", version.ref = "junit" }
+test-kotlin = { module = "org.jetbrains.kotlin:kotlin-test", version.ref = "kotlin" }
+test-androidx-core = { module = "androidx.test:core-ktx", version.ref = "androidx-test-core" }
+test-androidx-runner = { module = "androidx.test:runner", version.ref = "androidx-test-runner" }
+test-fragment = { module = "androidx.fragment:fragment-testing", version.ref = "androidx-fragment" }
 
 [plugins]
 android-application = { id = "com.android.application", version.ref = "agp" }
 android-library = { id = "com.android.library", version.ref = "agp" }
 jetbrains-kotlin-android = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin" }
 vanniktechMavenPublish = { id = "com.vanniktech.maven.publish", version.ref = "vanniktechMavenPublish" }
 parcelize = { id = "org.jetbrains.kotlin.plugin.parcelize", version.ref = "kotlin" }
+detekt = { id = "io.gitlab.arturbosch.detekt", version.ref = "detekt" }
+ktlint = { id = "org.jlleitschuh.gradle.ktlint", version.ref = "ktlint" }
+kover = { id = "org.jetbrains.kotlinx.kover", version.ref = "kover" }

vbpd-core/build.gradle.kts

@@ -5,4 +5,10 @@ plugins {
 dependencies {
     api(libs.androidx.viewbinding)
     implementation(libs.androidx.annotation)
+
+    testImplementation(libs.test.junit)
+    testImplementation(libs.test.kotlin)
+    testImplementation(libs.test.mockk)
+    testImplementation(libs.test.robolectric)
+    testImplementation(libs.test.androidx.core)
 }

vbpd-core/src/test/kotlin/dev/androidbroadcast/vbpd/EagerViewBindingPropertyTest.kt

@@ -0,0 +1,41 @@
+package dev.androidbroadcast.vbpd
+
+import android.view.View
+import androidx.viewbinding.ViewBinding
+import io.mockk.every
+import io.mockk.mockk
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.robolectric.RobolectricTestRunner
+import kotlin.test.assertEquals
+
+@RunWith(RobolectricTestRunner::class)
+class EagerViewBindingPropertyTest {
+
+    private fun createMockBinding(): ViewBinding {
+        val view = mockk<View>()
+        return mockk<ViewBinding> {
+            every { root } returns view
+        }
+    }
+
+    @Test
+    fun `getValue returns the provided binding`() {
+        val expectedBinding = createMockBinding()
+        val property = EagerViewBindingProperty<Any, ViewBinding>(expectedBinding)
+
+        val result = property.getValue(Any(), ::result)
+        assertEquals(expectedBinding, result)
+    }
+
+    @Test
+    fun `getValue always returns same instance`() {
+        val binding = createMockBinding()
+        val property = EagerViewBindingProperty<Any, ViewBinding>(binding)
+        val thisRef = Any()
+
+        val first = property.getValue(thisRef, ::first)
+        val second = property.getValue(thisRef, ::second)
+        assertEquals(first, second)
+    }
+}

vbpd-core/src/test/kotlin/dev/androidbroadcast/vbpd/LazyViewBindingPropertyTest.kt

@@ -0,0 +1,76 @@
+package dev.androidbroadcast.vbpd
+
+import android.view.View
+import androidx.viewbinding.ViewBinding
+import io.mockk.every
+import io.mockk.mockk
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.robolectric.RobolectricTestRunner
+import kotlin.test.assertEquals
+
+@RunWith(RobolectricTestRunner::class)
+class LazyViewBindingPropertyTest {
+
+    private fun createMockBinding(): ViewBinding {
+        val view = mockk<View>()
+        return mockk<ViewBinding> {
+            every { root } returns view
+        }
+    }
+
+    @Test
+    fun `getValue returns binding created by viewBinder`() {
+        val expectedBinding = createMockBinding()
+        val property = LazyViewBindingProperty<Any, ViewBinding> { expectedBinding }
+        val thisRef = Any()
+
+        val result = property.getValue(thisRef, ::result)
+        assertEquals(expectedBinding, result)
+    }
+
+    @Test
+    fun `getValue returns same instance on subsequent calls`() {
+        var callCount = 0
+        val binding = createMockBinding()
+        val property = LazyViewBindingProperty<Any, ViewBinding> {
+            callCount++
+            binding
+        }
+        val thisRef = Any()
+
+        val first = property.getValue(thisRef, ::first)
+        val second = property.getValue(thisRef, ::second)
+
+        assertEquals(first, second)
+        assertEquals(1, callCount, "viewBinder should be called only once")
+    }
+
+    @Test
+    fun `clear resets cached binding`() {
+        var callCount = 0
+        val property = LazyViewBindingProperty<Any, ViewBinding> {
+            callCount++
+            createMockBinding()
+        }
+        val thisRef = Any()
+
+        property.getValue(thisRef, ::thisRef)
+        property.clear()
+        property.getValue(thisRef, ::thisRef)
+
+        assertEquals(2, callCount, "viewBinder should be called again after clear()")
+    }
+
+    @Test
+    fun `viewBinder receives correct thisRef`() {
+        var receivedRef: Any? = null
+        val property = LazyViewBindingProperty<String, ViewBinding> { ref ->
+            receivedRef = ref
+            createMockBinding()
+        }
+
+        property.getValue("test", ::receivedRef)
+        assertEquals("test", receivedRef)
+    }
+}

vbpd-reflection/build.gradle.kts

@@ -18,4 +18,15 @@ dependencies {
     compileOnly(libs.androidx.recyclerview)
     compileOnly(libs.androidx.activity)
     api(projects.vbpd)
+
+    testImplementation(libs.test.junit)
+    testImplementation(libs.test.kotlin)
+    testImplementation(libs.test.mockk)
+    testImplementation(libs.test.robolectric)
+    testImplementation(libs.test.androidx.core)
+    testImplementation(libs.test.androidx.runner)
+    testImplementation(libs.androidx.fragment)
+    testImplementation(libs.androidx.activity)
+    testImplementation(libs.androidx.recyclerview)
+    testImplementation(libs.androidx.appcompat)
 }