Skip to content

Commit 2430e6e

Browse files
authored
fix(youtube-player): update to latest typings and fix error (#33387)
Updates to the latest typings for YouTube and fix a build failure that showed up.
1 parent eb2c033 commit 2430e6e

7 files changed

Lines changed: 278 additions & 255 deletions

File tree

‎goldens/youtube-player/index.api.md‎

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import { Observable } from 'rxjs';
1414
import { OnChanges } from '@angular/core';
1515
import { OnDestroy } from '@angular/core';
1616
import { SimpleChanges } from '@angular/core';
17-
import * as YT_2 from 'youtube';
1817

1918
// @public
2019
export type PlaceholderImageQuality = 'high' | 'standard' | 'low';
@@ -25,18 +24,18 @@ export const YOUTUBE_PLAYER_CONFIG: InjectionToken<YouTubePlayerConfig>;
2524
// @public
2625
export class YouTubePlayer implements AfterViewInit, OnChanges, OnDestroy {
2726
constructor();
28-
readonly apiChange: Observable<YT_2.PlayerEvent>;
27+
readonly apiChange: Observable<YT.PlayerEvent>;
2928
disableCookies: boolean;
3029
disablePlaceholder: boolean;
3130
endSeconds: number | undefined;
32-
readonly error: Observable<YT_2.OnErrorEvent>;
31+
readonly error: Observable<YT.OnErrorEvent>;
3332
getAvailablePlaybackRates(): number[];
34-
getAvailableQualityLevels(): YT_2.SuggestedVideoQuality[];
33+
getAvailableQualityLevels(): YT.SuggestedVideoQuality[];
3534
getCurrentTime(): number;
3635
getDuration(): number;
37-
getPlaybackQuality(): YT_2.SuggestedVideoQuality;
36+
getPlaybackQuality(): YT.SuggestedVideoQuality;
3837
getPlaybackRate(): number;
39-
getPlayerState(): YT_2.PlayerState | undefined;
38+
getPlayerState(): YT.PlayerState | undefined;
4039
getVideoEmbedCode(): string;
4140
getVideoLoadedFraction(): number;
4241
getVideoUrl(): string;
@@ -76,21 +75,21 @@ export class YouTubePlayer implements AfterViewInit, OnChanges, OnDestroy {
7675
pauseVideo(): void;
7776
placeholderButtonLabel: string;
7877
placeholderImageQuality: PlaceholderImageQuality;
79-
readonly playbackQualityChange: Observable<YT_2.OnPlaybackQualityChangeEvent>;
80-
readonly playbackRateChange: Observable<YT_2.OnPlaybackRateChangeEvent>;
81-
playerVars: YT_2.PlayerVars | undefined;
78+
readonly playbackQualityChange: Observable<YT.OnPlaybackQualityChangeEvent>;
79+
readonly playbackRateChange: Observable<YT.OnPlaybackRateChangeEvent>;
80+
playerVars: YT.PlayerVars | undefined;
8281
playVideo(): void;
83-
readonly ready: Observable<YT_2.PlayerEvent>;
82+
readonly ready: Observable<YT.PlayerEvent>;
8483
requestFullscreen(options?: FullscreenOptions): Promise<void>;
8584
seekTo(seconds: number, allowSeekAhead: boolean): void;
8685
setPlaybackRate(playbackRate: number): void;
8786
setVolume(volume: number): void;
8887
protected _shouldShowPlaceholder(): boolean;
8988
showBeforeIframeApiLoads: boolean;
9089
startSeconds: number | undefined;
91-
readonly stateChange: Observable<YT_2.OnStateChangeEvent>;
90+
readonly stateChange: Observable<YT.OnStateChangeEvent>;
9291
stopVideo(): void;
93-
suggestedQuality: YT_2.SuggestedVideoQuality | undefined;
92+
suggestedQuality: YT.SuggestedVideoQuality | undefined;
9493
unMute(): void;
9594
videoId: string | undefined;
9695
get width(): number;

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
"@angular/forms": "catalog:",
6565
"@angular/platform-browser": "catalog:",
6666
"@types/google.maps": "^3.54.10",
67-
"@types/youtube": "0.2.0",
67+
"@types/youtube": "0.3.0",
6868
"date-fns": "^4.1.0",
6969
"luxon": "^3.7.2",
7070
"moment": "^2.29.1",

‎pnpm-lock.yaml‎

Lines changed: 265 additions & 236 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/youtube-player/fake-youtube-player.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
* found in the LICENSE file at https://angular.dev/license
77
*/
88

9-
import type * as YT from 'youtube';
10-
119
// A re-creation of YT.PlayerState since enum values cannot be bound to the window object.
1210
const playerState = {
1311
UNSTARTED: -1,

‎src/youtube-player/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
},
1818
"homepage": "https://github.com/angular/components/tree/main/src/youtube-player#readme",
1919
"dependencies": {
20-
"@types/youtube": "0.2.0",
20+
"@types/youtube": "0.3.0",
2121
"tslib": "^2.3.0",
2222
"safevalues": "^1.2.0"
2323
},

‎src/youtube-player/youtube-player.spec.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import {
1515
YouTubePlayer,
1616
} from './youtube-player';
1717
import {PlaceholderImageQuality} from './youtube-player-placeholder';
18-
import type * as YT from 'youtube';
1918

2019
declare var window: Window;
2120

‎src/youtube-player/youtube-player.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
// Workaround for: https://github.com/bazelbuild/rules_nodejs/issues/1265
1010
/// <reference types="youtube" preserve="true" />
1111

12-
import type * as YT from 'youtube';
13-
1412
import {
1513
Component,
1614
ElementRef,

0 commit comments

Comments
 (0)