Conversation
Several method signatures declared a typed parameter with a null default (e.g. `string $key = null`) without the explicit `?` nullable marker, which PHP 8.4 deprecates. Under environments with display_errors on, the deprecation notices get echoed into the HTTP response body before the real tus response headers/status are sent, breaking the response (falls back to a bare 200).
…eStore::lock() Missed in the previous pass because it's only exercised via the FileStore cache backend, not RedisStore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some forbidden characters are in fact not invalid on either Windows or Linux. At least, it’s debatable whether these should be restricted at the library level. For example, the "&" character is commonly used in filenames by our users, so as the least drastic change, I’ve made this forbidden character list optionally overridable. Since this is not mandatory, it doesn’t break any existing functionality.
Thank you for your work, consider merging this PR