enforce min task duration

*to be revisited later with zero duration support

Author: anokta

platforms/godot/performer.cpp

@@ -24,8 +24,7 @@ void BarelyTaskResource::set_position(double position) {
 }
 
 void BarelyTaskResource::set_duration(double duration) {
-  static constexpr double kMinTaskDuration = 1e-6;
-  duration_ = std::max(duration, kMinTaskDuration);
+  duration_ = duration;
   emit_changed();
 }
 

platforms/unity/Assets/BarelyMusician/Scripts/Engine.cs

@@ -565,8 +565,7 @@ public static void Task_Create(Task task, UInt32 performerId, double position,
         if (taskId > 0 || Handle == IntPtr.Zero) {
           return;
         }
-        taskId = BarelyPerformer_CreateTask(_handle, performerId, position,
-                                            Math.Max(duration, _minTaskDuration), priority,
+        taskId = BarelyPerformer_CreateTask(_handle, performerId, position, duration, priority,
                                             Task_OnEvent, ref taskId);
         if (taskId == 0) {
           Debug.LogError("Failed to create task '" + task + "'");
@@ -590,7 +589,7 @@ public static bool Task_IsActive(UInt32 taskId) {
       }
 
       public static void Task_SetDuration(UInt32 taskId, double duration) {
-        BarelyTask_SetDuration(_handle, taskId, Math.Max(duration, _minTaskDuration));
+        BarelyTask_SetDuration(_handle, taskId, duration);
       }
 
       public static void Task_SetPosition(UInt32 taskId, double position) {
@@ -659,9 +658,6 @@ private static IntPtr Handle {
       }
       private static IntPtr _handle = IntPtr.Zero;
 
-      // Minimum task duration to avoid zero duration tasks.
-      private const double _minTaskDuration = 1e-6;
-
       // Denotes if the system is shutting down to avoid re-initialization.
       private static bool _isShuttingDown = false;
 

src/barelymusician.cpp

@@ -199,7 +199,7 @@ void BarelyInstrument_SetSampleData(BarelyEngine* engine, uint32_t instrument_id
 uint32_t BarelyPerformer_CreateTask(BarelyEngine* engine, uint32_t performer_id, double position,
                                     double duration, int32_t priority, BarelyTaskCallback callback,
                                     void* user_data) {
-  if (engine != nullptr && engine->IsValidPerformer(performer_id) && duration > 0.0) {
+  if (engine != nullptr && engine->IsValidPerformer(performer_id)) {
     const uint32_t task_index = engine->controller.performer_controller().AcquireTask(
         engine->state.GetIdIndex(performer_id), position, duration, priority, callback, user_data);
     if (task_index != barely::kInvalidIndex) {
@@ -291,7 +291,7 @@ void BarelyTask_SetCallback(BarelyEngine* engine, uint32_t task_id, BarelyTaskCa
 }
 
 void BarelyTask_SetDuration(BarelyEngine* engine, uint32_t task_id, double duration) {
-  if (engine != nullptr && engine->IsValidTask(task_id) && duration > 0.0) {
+  if (engine != nullptr && engine->IsValidTask(task_id)) {
     engine->controller.performer_controller().SetTaskDuration(engine->state.GetIdIndex(task_id),
                                                               duration);
   }

src/core/constants.h

@@ -15,7 +15,7 @@ inline constexpr uint32_t kInvalidIndex = UINT32_MAX;
 inline constexpr float kMaxDelayFeedback = 0.9995f;
 
 // Minimum filter frequency in hertz.
-static constexpr float kMinFilterFreq = 20.0f;
+inline constexpr float kMinFilterFreq = 20.0f;
 
 // Reference frequency which is tuned to middle C in hertz.
 inline constexpr float kReferenceFreq = 261.62555f;

src/engine/performer_controller.cpp

@@ -51,7 +51,10 @@ uint32_t PerformerController::AcquireTask(uint32_t performer_index, double posit
   const uint32_t task_index = engine_.task_pool.Acquire();
   if (task_index != kInvalidIndex) {
     TaskState& task = engine_.GetTask(task_index);
-    task = {{callback, user_data}, position, duration, priority, performer_index};
+    task = {
+        {callback, user_data}, position, std::max(duration, kMinTaskDuration), priority,
+        performer_index,
+    };
     InsertInactiveTask(engine_.GetPerformer(performer_index), task_index);
   }
   return task_index;
@@ -140,9 +143,9 @@ void PerformerController::Stop(uint32_t performer_index) noexcept {
 }
 
 void PerformerController::SetTaskDuration(uint32_t task_index, double duration) noexcept {
-  assert(duration > 0.0 && "Invalid task duration");
   auto& task = engine_.GetTask(task_index);
   auto& performer = engine_.GetPerformer(task.performer_index);
+  duration = std::max(duration, kMinTaskDuration);
   if (task.duration == duration) return;
   task.duration = duration;
   if (task.is_active) {

src/engine/performer_state.h

@@ -3,6 +3,7 @@
 
 #include <barelymusician.h>
 
+#include <cfloat>
 #include <cmath>
 #include <cstdint>
 
@@ -11,6 +12,8 @@
 
 namespace barely {
 
+inline constexpr double kMinTaskDuration = DBL_EPSILON;
+
 struct PerformerState {
  public:
   double loop_begin_position = 0.0;
@@ -38,7 +41,7 @@ struct TaskState {
   Callback<BarelyTaskCallback> callback = {};
 
   double position = 0.0;
-  double duration = 0.0;
+  double duration = kMinTaskDuration;
   int32_t priority = 0;
 
   uint32_t performer_index = kInvalidIndex;