fix(core): treat non-zero shell exit at schedule creation as not yet

Author: kitlangton

packages/core/src/schedule.ts

@@ -642,9 +642,7 @@ const layer = Layer.effect(
                   ),
                 )
                 const shouldSeed =
-                  check.mode === "until" ||
-                  when.type === "every" ||
-                  (check.condition.type === "shell" && check.condition.changes === true)
+                  check.mode === "until" || (check.condition.type === "shell" && check.condition.changes === true)
                 if (!shouldSeed) return { matched: false as const, state: null as Schema.Json, checks: 0 }
                 const init = yield* ScheduleCheck.evaluate(session, check, null).pipe(
                   instances.provide(session),
@@ -654,7 +652,8 @@ const layer = Layer.effect(
                     ),
                   ),
                 )
-                if (!init.ok) return yield* new InvalidError({ reason: init.error })
+                // A target that is not up yet (e.g. curl exiting 7 while a server boots) is "not yet", not an invalid schedule.
+                if (!init.ok) return { matched: false as const, state: null as Schema.Json, checks: 0 }
                 if (check.mode === "until" && init.wake)
                   return { matched: true as const, state: init.state, message: init.message }
                 return { matched: false as const, state: init.state, checks: 1 }

packages/core/test/schedule.test.ts

@@ -983,16 +983,20 @@ describe("Schedule", () => {
       }),
     )
 
-    it.effect("supports is and matches predicates", () =>
+    it.effect("supports is and matches predicates, even when the command exits non-zero at creation", () =>
       Effect.gen(function* () {
         const schedules = yield* setup()
-        shellState.stdout = "OPEN\n"
+        // Service is still booting at creation (curl exits 7); creating an `until` with `is` still succeeds.
+        shellState.exitCode = 7
+        shellState.stdout = ""
         const exact = yield* schedules.create({
           sessionID,
           when: { type: "every", every: "20 seconds" },
-          until: { type: "shell", run: "gh pr view 1", is: "MERGED" },
+          until: { type: "shell", run: "curl -sf http://localhost:3000/status", is: "MERGED" },
           action: { type: "prompt", prompt: "Merged." },
         })
+        shellState.exitCode = 0
+        shellState.stdout = "OPEN\n"
         const regex = yield* schedules.create({
           sessionID,
           when: { type: "every", every: "20 seconds" },