refactor(core): use cached borrowing for pending reads

Author: milimarenko

packages/core/src/effect/app-node-builder.ts

@@ -2,7 +2,7 @@ import { buildLocationServiceMap } from "../location-services.js"
 import { LocationServiceMap } from "../location-service-map.js"
 import { LayerNode } from "@opencode/util/effect/layer-node"
 import { makeGlobalNode } from "@opencode/util/effect/app-node"
-import { Effect, Layer, RcMap } from "effect"
+import { Effect, Layer } from "effect"
 import { Instance } from "../instance/service.js"
 
 const instances = makeGlobalNode({
@@ -13,7 +13,6 @@ const instances = makeGlobalNode({
       const locations = yield* LocationServiceMap.Service
       return Instance.Service.of({
         provide: (session) => Effect.provide(locations.get(session.location)),
-        live: (session) => RcMap.has(locations.rcMap, LocationServiceMap.canonical(session.location)),
         provideCached: (session) => Instance.cached(locations, LocationServiceMap.canonical(session.location)),
       })
     }),

packages/core/src/instance/service.ts

@@ -12,8 +12,6 @@ export interface Interface {
   readonly provide: (
     session: Session.Info,
   ) => <A, E, R>(effect: Effect.Effect<A, E, R>) => Effect.Effect<A, E | Error, Exclude<R, Services>>
-  /** Whether `provide` would reuse built or booting capabilities. Selectors without it are assumed live. */
-  readonly live?: (session: Session.Info) => Effect.Effect<boolean>
   readonly provideCached: (
     session: Session.Info,
   ) => <A, E, R>(effect: Effect.Effect<A, E, R>) => Effect.Effect<Option.Option<A>, E | Error, Exclude<R, Services>>

packages/sdk/src/internal/instances.ts

@@ -7,7 +7,7 @@ import type { InstancePlugins } from "@opencode/core/plugin/instance"
 import type { Session } from "@opencode/schema/session"
 import { makeGlobalNode } from "@opencode/util/effect/app-node"
 import type { LayerNode } from "@opencode/util/effect/layer-node"
-import { Context, Duration, Effect, Layer, LayerMap, RcMap, Scope } from "effect"
+import { Context, Duration, Effect, Layer, LayerMap, Scope } from "effect"
 
 export interface Configuration {
   readonly plugins: InstancePlugins.List
@@ -102,7 +102,7 @@ export function layer(options: Options, replacements: () => LayerNode.Replacemen
           ),
         { idleTimeToLive: Duration.infinity },
       )
-      return Instance.Service.of({ provide, provideCached, live: (session) => RcMap.has(instances.rcMap, key(session)) })
+      return Instance.Service.of({ provide, provideCached })
     }),
   )
 }

packages/server/src/middleware/form-location.ts

@@ -3,7 +3,7 @@ import { LocationServiceMap } from "@opencode/core/location-services"
 import { Session } from "@opencode/core/session"
 import { LocationNotFoundError, InvalidRequestError, SessionNotFoundError } from "@opencode/protocol/errors"
 import { Effect, Layer } from "effect"
-import { HttpRouter, HttpServerRequest, HttpServerResponse } from "effect/http"
+import { HttpRouter, HttpServerRequest } from "effect/http"
 import { HttpApiMiddleware } from "effect/http-api"
 import { locationErrors, requestRef, sessionInfo, type LocationServices } from "../location"
 
@@ -21,7 +21,7 @@ export const formLocationLayer = Layer.effect(
     const instances = yield* Instance.Service
     const locations = yield* LocationServiceMap.Service
 
-    return FormLocationMiddleware.of((effect, options) =>
+    return FormLocationMiddleware.of((effect) =>
       Effect.gen(function* () {
         const route = yield* HttpRouter.RouteContext
         if (route.params.sessionID === "global") {
@@ -33,10 +33,6 @@ export const formLocationLayer = Layer.effect(
         }
 
         const session = yield* sessionInfo(sessions, route.params.sessionID)
-        // Forms live in memory, so a Session without live capabilities has none pending. Listing must
-        // not boot its Location: clients poll whole subagent trees, including deleted worktrees.
-        if (options.endpoint.identifier === "session.form.list" && instances.live && !(yield* instances.live(session)))
-          return HttpServerResponse.jsonUnsafe({ data: [] })
         return yield* effect.pipe(instances.provide(session), locationErrors)
       }),
     )