Repository navigation
fix(ci): release v1 without the OpenCode Agent app token - #59665
Merged
Merged
Conversation
Member
Author
|
Dry run: preview
— from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
This week's CI lockdown deleted
OPENCODE_APP_ID/OPENCODE_APP_SECRET, bound npm trusted publishing to thereleaseenvironment and limited pushes tov1andv*tags. With those changes, every v1publish.ymlrun fails, previews included. This PR makes v1 releasable with the smallest change.latest*.ymluploads andgh release edit --latestusegithub.token(the workflow already hascontents: write). Git identity comes from the existing AUR step (opencode <opencode@sst.dev>).v1use theRELEASE_TAG_KEYdeploy key, set throughactions/checkoutssh-keyinpublish, only on versioned runs. Thev*tag ruleset already allows deploy keys.DeployKeywas added to thev1ruleset (25933885) bypass list so thesync release versionscommit can land.publishruns inreleaseon v1, for previews too, because npm trusted publishing now only accepts that environment.anomalyco/homebrew-tapover SSH withHOMEBREW_TAP_DEPLOY_KEY, like dev.github.tokencan't push to another repo.sign-cli-macosand the macOSbuild-electronlegs run inreleaseon v1 and readAPPLE_SIGNING_CERTIFICATE(no password),APPLE_NOTARY_KEYand varsAPPLE_NOTARY_KEY_ID/APPLE_NOTARY_ISSUER_IDwhen present. Otherwise they fall back to the current repo-levelAPPLE_CERTIFICATE/_PASSWORD/APPLE_API_KEY_PATH/APPLE_API_KEY/APPLE_API_ISSUER. This works before and after the move. Windows legs keep their current Azure login subject (no environment).latest.json(signed with the Tauri updater key, used only by legacy Tauri desktop installs) is skipped whenTAURI_SIGNING_PRIVATE_KEYis unset. That key was deleted. Without this change,script/publish.tswould throw after npm publish and before tagging, leaving a half-finished release.Not changed, still needs attention:
nix-hashes.ymlon v1 still uses the app token, so it will fail on the post-release sync commit. This doesn't block releases.opencode-beta) releases need a cross-repo token and won't work withgithub.token.github.tokendon't triggerrelease: releasedworkflows (Discord notify).How did you verify your code works?
actionlint(no new findings; runner-label warnings only),bun build --no-bundleon both scripts.publish.ymldispatch on a copy of this branch with thepublishjob disabled (results in the PR comments). Release-environment paths (deploy keys, new Apple names, npm OIDC) can only be exercised onv1. The first push tov1after merge runs a preview, which checks npm publish inrelease.Checklist