Repository navigation
cleanup: remove dead code - #59672
Open
rekram1-node wants to merge 1 commit into
Open
rekram1-node wants to merge 1 commit into
rekram1-node wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
packages/core had a few things nothing uses anymore, plus a stray one-line editor prompt (
src/effect/dfdf) that got committed by mistake.Change
Deletion only. I grepped the whole repo (all packages, tests, scripts, the
./*export pattern) before removing each one.I also dropped the unused imports oxlint flags in packages/core (src and test). Bun strips unused imports at runtime and in
bun build, even withverbatimModuleSyntax, so none of these were loading anything. I checked that with a tiny side-effect repro.Out of scope
Unused variables oxlint reports in core (like
aisdkandplugin). I only touched imports.Verification
bun typecheckin packages/core, packages/opencode, packages/app and packages/session-ui: passbun test test/shell.test.ts test/npm.test.ts test/project.test.tsin packages/core: 21 pass