Repository navigation
fix(ci): sign v1 with release environment credentials and publish only from v1 - #59782
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1 publish run 40565869462 failed in
sign-cli-macosand both macOSbuild-electronjobs.apple-actions/import-codesign-certsrejects the empty password of the new passwordless certificate.Signing (ported from #59768)
apple-actions/import-codesign-certswith a run step. It decodesAPPLE_SIGNING_CERTIFICATEto$RUNNER_TEMP, createsbuild.keychainwith a random password, imports with-P "", sets the partition list and adds the keychain to the search list. Anif: always()step deletes the keychain, the .p12 and the .p8. The keychain name is stillbuild.keychain, whichCSC_KEYCHAINand the CLI signing step expect.APPLE_API_KEY(the path to the .p8 written fromsecrets.APPLE_NOTARY_KEY),APPLE_API_KEY_ID(vars.APPLE_NOTARY_KEY_ID) andAPPLE_API_ISSUER(vars.APPLE_NOTARY_ISSUER_ID). Fallbacks toAPPLE_CERTIFICATE,APPLE_CERTIFICATE_PASSWORD,APPLE_API_KEY,APPLE_API_KEY_PATHandAPPLE_API_ISSUERare removed.sign-cli-macos,sign-cli-windows,build-electron(all matrix entries) andpublishnow run inenvironment: releaseunconditionally. Azure login already works in the release environment on dev'srelease.yml.Publish only from v1
publish.yml: the push trigger is nowv1only. Removedci,beta,fix/npm-native-binary-installandsnapshot-*.versionrequiresgithub.ref == 'refs/heads/v1', andpublishrequiresneeds.version.result == 'success', so a dispatch on any other ref publishes nothing.opencode-betaGH_REPO,--sourcemaps, the betaOPENCODE_CHANNELand the beta Sentry environment frompublish.yml, plus the beta draft-release branch inscript/version.ts.nix-hashes.yml: dropped thebetapush trigger. The commit job only runs on v1.containers.ymlandunlock.yml(dispatch): the job only runs on v1.publish-vscode.ymlandpublish-github-action.yml: a dispatch only runs on v1, and a tag must point at a commit that is an ancestor oforigin/v1.Checks
blacksmith-*runner labels plus 2 existing issues indocs-locale-sync.ymlandgenerate.yml.bash -npasses on every run step in the touched workflows. oxlint passes onscript/version.ts.Merging
Merging is a push to
v1. It startspublish.ymlwith no approval, because thereleaseenvironment only has a branch policy (dev and v1) and no required reviewers. That run publishes a0.0.0-dev-<timestamp>preview to npm under thedevdist-tag. It does not create a GitHub release, Docker image, AUR package or Homebrew update.deploy.yml,generate.yml,test.yml,typecheck.ymlandnix-eval.ymlalso run on that push.