Repository navigation
fix(ci): create v1 draft release without --target - #59832
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1 publish run fails at
gh release createwithHTTP 403: Resource not accessible by integration.When a release is created with a target commit whose workflow files differ from the default branch, GitHub also requires the
workflowspermission.github.tokencan't be granted that, and v1's workflows always differ from dev's. The old app token had it, so this broke when #59665 switched togithub.token. See cli/cli#9514.Dropping
--targetmakes it the same call dev uses. A draft doesn't create its tag, andscript/publish.tsalready pushesv<version>with the deploy key before publishing the release, so the draft picks the tag up there. No manual tag push needed.