Repository navigation
chore(process-daemon): release 0.3.3 - #59969
Conversation
There was a problem hiding this comment.
The change looks sound. Drafting first, publishing npm, then publishing the GitHub release last is the right order given immutable releases. Each step checks the release's state, so a re-run of the failed job picks up where it stopped in every partial state in your table. If gh release view fails unexpectedly, create fails on the existing release and the job stops, which is the safe result. I couldn't run the tag-only steps here. I checked that the workflow YAML parses, that bash -n passes on every release-job script, and that the versions in Cargo.toml, Cargo.lock and npm/package.json all agree on 0.3.3 as the tag validation requires. Nothing in the npm packages reads GitHub release assets, so npm packages going live before the release is published won't break installs.
Public API: unchanged (CI workflow plus a version bump of @opencode/pty).
No concerns.
8334802 to
ce9d076
Compare
There was a problem hiding this comment.
Since my last review the workflow and README changes were dropped, and this is now just the 0.3.3 bump. It's consistent: Cargo.toml, the opencode-pty entry in Cargo.lock, and npm/package.json (version and all 8 optionalDependencies) all read 0.3.3, as the workflow's tag validation requires.
Public API: unchanged.
One risk worth noting: the release job on dev still publishes the GitHub release before npm. If npm publishing fails again for 0.3.3, the immutable release will be locked the same way as 0.3.2 and need another patch version. With the trusted publisher fixed this should be fine, so it's not blocking.
Issue for this PR
Closes #
Type of change
What does this PR do?
Bumps process-daemon (
opencode-pty/@opencode/pty) from 0.3.2 to 0.3.3. The 0.3.2 GitHub release was published, but npm publishing failed because the trusted publisher was misconfigured (since fixed; see https://github.com/anomalyco/opencode/actions/runs/40718483791). Immutable releases lock theprocess-daemon-v0.3.2tag, so we can't re-run it and need a new version.This changes only
Cargo.toml, theopencode-ptyentry inCargo.lock, andnpm/package.json(version plus all 8 platform optionalDependencies). It makes no workflow changes.After merge, tag
process-daemon-v0.3.3at the merge commit to run the release.How did you verify your code works?
cargo run --locked -- --versionprintsopencode-pty 0.3.3 (protocol 7).npm/package.jsonversion and all optionalDependencies are0.3.3.Checklist