Repository navigation
fix(app): list side launchers only in a New tab and close the region with its last tab - #60126
Merged
Merged
Conversation
…with its last tab
opencode-agent
Bot
requested review from
Brendonovich and
Hona
as code owners
October 29, 2026 06:23
![opencodejr[bot]](https://avatars.githubusercontent.com/in/5497873?s=60&v=4){kind=small}
There was a problem hiding this comment.
The change looks sound: closing the last New tab now goes through the same onEmptied path as closing the last real tab. The keyboard close-tab shortcut goes through it too, and the existing "open a New tab when the region opens empty" effect handles reopening. I reviewed the code and type-checked packages/app (passes), but I could not run the web app or the new Playwright test here because no browser is available. Could you add before/after screenshots or a short video of the side region (the empty state, and closing the last New tab)?
Public API: unchanged (app UI internals only).
kitlangton
added a commit
that referenced
this pull request
Oct 30, 2026
#60126 made closing a strip's last New tab close the side region, as closing its last tab does. #59002 assumed the panel stayed open after that press and then refocused the closed panel, so its e2e failed on dev. The region now gives focus back to where it was opened from whenever emptying it closes it, and ⌘W only keeps focus in the panel while it is still open. The e2e expectation is updated to #60126's intended behaviour: the first ⌘W closes the New tab with the panel, the next press closes nothing, and only then does ⌘W close the session tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The side region's launcher list (Review, Browser, Terminal, Open file, Recently closed) now shows only inside a New tab.
Adds an e2e regression for closing the last New tab and reopening the region. Typecheck and
lint:changedpass. The e2e suite couldn't run locally because Chromium couldn't launch on the host, so CI will run it.Requested by: @Brendonovich (Brendan via Slack)