Repository navigation
Conversation
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
There was a problem hiding this comment.
Looks good. I ran the reproduction from #42181 with opencode-drive at 120×36 on the base and on this branch. On the base, the Status title, "No MCP servers" and the esc hint are one column off from the command palette. With this change they line up exactly. DialogLayout uses inset as side padding for the header, body and footer, so this one prop covers all three, the same way dialog-fork.tsx already does it. The new test passes here and fails on the base. tsc -b in packages/tui passes, and the branch merges cleanly with the latest dev.
Public API: unchanged.
The test is clear and doesn't look flaky, but 43 lines is a lot for a one-prop fix. You could cut it down to a single case (one width, no MCP server), or drop it to keep the change minimal.
afaae24 to
69b8be2
Compare
There was a problem hiding this comment.
The new commit cuts the test down to a single small case, which addresses my earlier note. The fix itself is unchanged. I re-ran the reproduction from #42181 at 120×36 on the current base and on this branch. On the base, Status is still one column off from the command palette. With this change, the title, body text and esc hint line up. The test passes and tsc -b in packages/tui passes.
Public API: unchanged.
I found nothing new that should block it.




Issue for this PR
Closes #42181
Type of change
What does this PR do?
Status uses the default 3-cell
DialogLayoutinset, while pickers align their content at 4 cells. Pass the existingDIALOG_LIST_INSETto Status so its title, body, and escape hint line up with pickers.This adapts the Status part of #43728 to the current layout API. The old PR was closed by automated cleanup. Other dialogs are unchanged.
How did you verify your code works?
A single renderer regression compares empty Status with
DialogSelectat 100 columns, checking the title, body, and escape hint. Removing the inset fix makes it fail by one column.bun run testinpackages/tui): 1,645 passed, 2 skipped, 0 failed.bun run check: lint completed without errors and all 35 typecheck tasks passed.bun run typecheck:tscinpackages/tuipassed.git diff --checkpass.Verified locally with Bun 1.4.4.
Visual
Illustration of the alignment change (not a renderer capture):
Screenshots / recordings
Before: current-dev reproduction with recording and screenshots.
After, at 120×32:
Command palette at the same terminal size for comparison:
Checklist