Skip to content

fix(core): resolve app version from package metadata - #61337

Closed
toidicakhia wants to merge 1 commit into
anomalyco:v2from
toidicakhia:v2
Closed

toidicakhia wants to merge 1 commit into
anomalyco:v2from
toidicakhia:v2

Conversation

@toidicakhia

Copy link
Copy Markdown

Summary

  • Fall back to the package version when the build-time version is local or missing, instead of emitting local/unknown.
  • Default an unknown channel to latest when formatting the user agent.
  • Add coverage for the fallback behavior in App.useragent.

Verification

  • bun test test/app.test.ts in packages/core
  • bun typecheck in packages/core and packages/cli
  • Pre-push bun run check: typecheck passed for all 36 packages

Fall back to the package version instead of emitting local or unknown in app metadata and user agents, and default an unknown channel to latest.
@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 72 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@opencodejr opencodejr Bot closed this Nov 3, 2026
@opencodejr

opencodejr Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Thanks for putting this together, @toidicakhia!

On 2026-10-10 the v2 branch was promoted to dev, and v2 work now happens on dev. This pull request targets v2, which is no longer used, so it's being closed.

Please open a new pull request with dev as the base. You can reuse the same branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:compliance This means the issue will auto-close after 2 hours. needs:issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant