Repository navigation
fix(opencode): cancel pending tool approvals with their owner - #61360
Open
WanderWang wants to merge 2 commits into
Open
WanderWang wants to merge 2 commits into
WanderWang wants to merge 2 commits into
Conversation
Bind all tool callback fibers to their owner signal, including a pre-aborted guard before synchronous evaluation. Cancellation must prevent old approvals from executing tools. Register permission cleanup before Asked publication and publish the existing reject settlement only for an entry still owned by that ask. This removes online permission cards without duplicate replies or deleting replacement requests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #61358
Type of change
What does this PR do?
Cancelling a V1 session must end its tool's permission wait and remove the connected client's card. Bind the five tool Promise callbacks to their existing AbortSignal, including signals aborted before entry.
Bracket permission publication and waiting with owner-checked cleanup. Cleanup emits the existing
permission.repliedrejection when it removes the request. Normal replies keep their existing settlement and policy.This targets the affected
v1maintenance branch. It does not change V2, permission policy, or the wire schema.How did you verify your code works?
bun typecheckpasses.Screenshots / recordings
The client rendering code is unchanged. The live terminal check verified removal through the existing native event, without restarting or refreshing the TUI.
Checklist