fix(mcp-builder): specify utf-8 encoding in evaluation.py file writes (#1669) - #1683
Open
LuckTerence wants to merge 1 commit into
Open
fix(mcp-builder): specify utf-8 encoding in evaluation.py file writes (#1669)#1683LuckTerence wants to merge 1 commit into
LuckTerence wants to merge 1 commit into
Conversation
…anthropics#1669) Signed-off-by: LuckTerence <xihuan1127@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1669
Problem
In
skills/mcp-builder/scripts/evaluation.py, the evaluation report is written usingargs.output.write_text(report)without specifying an encoding. On Windows systems where the default locale encoding iscp1252, attempting to write reports containing emoji markers (✅,❌) or non-ASCII characters results in aUnicodeEncodeError. Because this occurs on the final write step after all evaluation tasks have finished, the entire run's output is lost.Fix
Added explicit
encoding="utf-8"toargs.output.write_text(report, encoding="utf-8")inskills/mcp-builder/scripts/evaluation.py.Testing
py_compile.