Repository navigation
Conversation
|
I hope I didn't miss anything. |
| - helm-tests/**/* | ||
| - kubernetes-tests/**/* | ||
| - task-sdk-integration-tests/**/* | ||
| - providers/**/tests/**/* |
There was a problem hiding this comment.
This will not work.
It will add the test label to any PR that modifies test files. This means that the label will be added to all PRs.
The task is to add the labels to PRs that changes only test files.
There was a problem hiding this comment.
This will not work. It will add the test label to any PR that modifies test files. This means that the label will be added to all PRs.
The task is to add the labels to PRs that changes only test files.
Thanks for the clarification. I misunderstood the requirement.
There was a problem hiding this comment.
Yeah. This is a bit more complex :)
There was a problem hiding this comment.
Yeah. This is a bit more complex :)
Should we automatically remove the label if the contributor adds non-test files?
There was a problem hiding this comment.
Yeah, we shouldn't add labels in such cases.
There was a problem hiding this comment.
But I do not know if boring cyborg has a technical limitation on that
38bc882 to
1386fec
Compare
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| --- | ||
| name: Label tests-only PRs |
There was a problem hiding this comment.
We have a boring cyborg to do it, can't we do it there: https://github.com/apache/airflow/blob/main/.github/boring-cyborg.yml?
There was a problem hiding this comment.
We have a boring cyborg to do it, can't we do it there: https://github.com/apache/airflow/blob/main/.github/boring-cyborg.yml?
Thanks for reviewing! I think we need additional logic to verify that every changed file is a test file, which is why a GitHub Actions workflow is needed.
|
This will not work. pull request workflow from fork cannot have write permissions. |
|
this can really be done only via app - you can add feature to boring cyborg for that if missing. |
closes: #61377
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.