Skip to content

Fix deferrable autofix inserting a forbidden conf import in providers - #72366

Open
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:airflow-deferrable-autofix-compat-conf
Open

Fix deferrable autofix inserting a forbidden conf import in providers#72366
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:airflow-deferrable-autofix-compat-conf

Conversation

@FrankYang0529

Copy link
Copy Markdown
Member

Why

  • check-deferrable-default rewrites operator and sensor files in place and adds from airflow.configuration import conf. check-conf-import-in-providers forbids that import in provider code, so the two hooks contradict each other.

How

  • Change check-deferrable-default to from airflow.providers.common.compat.sdk to conf.

Verification

  • uv run --project scripts pytest scripts/tests/ci/prek/test_check_deferrable_default.py

Was generative AI tooling used to co-author this PR?
  • Yes - Claude Code

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant