Skip to content

Deduplicate API response result conversions - #73037

Closed
fat-catTW wants to merge 1 commit into
apache:mainfrom
fat-catTW:refactor-api-response-result-conversion
Closed

fat-catTW wants to merge 1 commit into
apache:mainfrom
fat-catTW:refactor-api-response-result-conversion

Conversation

@fat-catTW

Copy link
Copy Markdown
Contributor

Why

Several task execution comms result classes repeated the same API response conversion logic, making each wrapper manually copy response fields and set the result discriminator.

Changing comms.py also runs the supervisor schema version hook, which needs to compare against a temporary upstream/main worktree. That hook could fail from git commit when it inherited Git-local hook environment variables.

Solution

Add shared mixins for the common conversion shapes:

  • _APIResponseResultMixin handles API response wrappers that only need model_dump(exclude_defaults=True).
  • _TypedAPIResponseResultMixin also restores the type discriminator required by task comms serialization.

Update the matching result wrappers to use from_api_response(). Keep custom converters where the shape is different, such as ConnectionResult needing by_alias=True, AssetsByAliasResult mapping a list of assets, and XCom sequence wrappers extracting root.

Also clear Git-local hook environment variables when the supervisor schema version check creates the temporary upstream worktree, so the hook works correctly from git commit.

Was generative AI tooling used to co-author this PR?
  • [X] Yes (please specify the tool below)

Generated-by: [Codex] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@Vamsi-klu Vamsi-klu left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

​

@fat-catTW
fat-catTW force-pushed the refactor-api-response-result-conversion branch from dd81738 to d6e96ce Compare September 14, 2026 15:03
@fat-catTW

Copy link
Copy Markdown
Contributor Author

Tests are added!
Thanks for the review.

@potiuk potiuk added the closed because of open PR limit Closed as a one-time step of introducing the open pull request limit label Sep 25, 2026
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @fat-catTW - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 17 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

@potiuk potiuk closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dag-processor area:dev-tools area:task-sdk closed because of open PR limit Closed as a one-time step of introducing the open pull request limit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants