Repository navigation
Conversation
014cb4b to
dd81738
Compare
dd81738 to
d6e96ce
Compare
|
Tests are added! |
|
Hello @fat-catTW - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 17 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Why
Several task execution comms result classes repeated the same API response conversion logic, making each wrapper manually copy response fields and set the result discriminator.
Changing
comms.pyalso runs the supervisor schema version hook, which needs to compare against a temporaryupstream/mainworktree. That hook could fail fromgit commitwhen it inherited Git-local hook environment variables.Solution
Add shared mixins for the common conversion shapes:
_APIResponseResultMixinhandles API response wrappers that only needmodel_dump(exclude_defaults=True)._TypedAPIResponseResultMixinalso restores thetypediscriminator required by task comms serialization.Update the matching result wrappers to use
from_api_response(). Keep custom converters where the shape is different, such asConnectionResultneedingby_alias=True,AssetsByAliasResultmapping a list of assets, and XCom sequence wrappers extractingroot.Also clear Git-local hook environment variables when the supervisor schema version check creates the temporary upstream worktree, so the hook works correctly from
git commit.Was generative AI tooling used to co-author this PR?
[X]Yes (please specify the tool below)Generated-by: [Codex] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.