Skip to content

Add password grant type to Snowflake OAuth token requests - #74804

Merged
shahar1 merged 17 commits into
apache:mainfrom
frodo2000:snowflake-oauth2-password
Oct 17, 2026
Merged

shahar1 merged 17 commits into
apache:mainfrom
frodo2000:snowflake-oauth2-password

Conversation

@frodo2000

Copy link
Copy Markdown
Contributor

Added password grant_type to oauth2 token generation for Snowflake - needed by some IdM
Covered by additional test - test_get_oauth_token_with_password_grant_type
Airflow pre-commit test passed


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

@frodo2000
frodo2000 requested a review from potiuk as a code owner October 15, 2026 14:50
@boring-cyborg boring-cyborg Bot added area:providers kind:documentation provider:snowflake Issues related to Snowflake provider labels Oct 15, 2026

@Eason09053360 Eason09053360 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! One small fix inline

Comment thread providers/snowflake/docs/connections/snowflake.rst
Comment thread providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake.py Outdated
@shahar1 shahar1 changed the title Snowflake oauth2 password (fork repository fix) Add password grant type to Snowflake OAuth token requests Oct 17, 2026

@shahar1 shahar1 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following review was drafted by AI using Apache Magpie and Claude Fable -
I went over it and confirmed its findings.
Also, I adjusted the PR's title according to the guidelines.

Comment thread providers/snowflake/provider.yaml Outdated
Comment thread providers/snowflake/docs/connections/snowflake.rst Outdated
Comment thread providers/snowflake/docs/connections/snowflake.rst Outdated
Comment thread providers/snowflake/tests/unit/snowflake/hooks/test_snowflake.py
Comment thread providers/snowflake/docs/connections/snowflake.rst

@shahar1 shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last minor comments and nits to handle, but overall LGTM

Comment thread providers/snowflake/docs/connections/snowflake.rst Outdated
Comment thread providers/snowflake/tests/unit/snowflake/hooks/test_snowflake.py Outdated
@shahar1
shahar1 self-requested a review October 17, 2026 15:51
@shahar1
shahar1 merged commit dba55d8 into apache:main Oct 17, 2026
85 checks passed
@frodo2000
frodo2000 deleted the snowflake-oauth2-password branch October 17, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snowflake Oauth2 Password mode

3 participants