Skip to content

fix(removeFromPbxSourcesBuildPhase): Remove based on UUID and filename - #204

Open
erisu wants to merge 1 commit into
apache:masterfrom
erisu:fix/removeFromPbxSourcesBuildPhase
Open

erisu wants to merge 1 commit into
apache:masterfrom
erisu:fix/removeFromPbxSourcesBuildPhase

Conversation

@erisu

@erisu erisu commented Nov 9, 2026

Copy link
Copy Markdown
Member

Resolves #202

When removing from PBXSourcesBuildPhase, instead of matching the file based on the complete comment line, it will now match based on the UUID & only the filename from comment. The "in " will be ignored.

@erisu erisu changed the title fix: removeFromPbxSourcesBuildPhase based on UUID and filename only fix(removeFromPbxSourcesBuildPhase): Remove based on UUID and filename Nov 9, 2026
@codecov-commenter

codecov-commenter commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.43%. Comparing base (2dd8d31) to head (538b0c9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files          52       52           
  Lines       11250    11250           
=======================================
  Hits        10961    10961           
  Misses        289      289           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erisu
erisu force-pushed the fix/removeFromPbxSourcesBuildPhase branch from a0816b5 to 538b0c9 Compare November 9, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

removeSourceFile finds the Sources build phase entry by its comment, so a .mm added by 4.0.0 leaves its entry behind

3 participants