always return a Buffer from attachment.get. Fixes issue #373 (#374)

Co-authored-by: Glynn Bird <glynnbird@apache.org>

Author: glynnbird

lib/nano.js

@@ -148,7 +148,7 @@ module.exports = exports = function dbScope (cfg) {
       // when doing head requests, we return the response headers, not the response body
       if (req.method === 'head') {
         retval = Object.fromEntries(response.headers)
-      } else if (contentType && contentType.startsWith('application/json')) {
+      } else if (contentType && contentType.startsWith('application/json') && !opts.dontParse) {
         try {
           retval = await response.json()
         } catch {

package-lock.json

@@ -4,7 +4,7 @@
   "license": "Apache-2.0",
   "homepage": "http://github.com/apache/couchdb-nano",
   "repository": "http://github.com/apache/couchdb-nano",
-  "version": "11.0.6",
+  "version": "11.0.7",
   "author": "Apache CouchDB <dev@couchdb.apache.org> (http://couchdb.apache.org)",
   "keywords": [
     "couchdb",

package.json

@@ -43,6 +43,21 @@ test('should be able to get an attachment with opts - GET /db/id/attname - db.at
   mockAgent.assertNoPendingInterceptors()
 })
 
+test('should be able to get a JSON attachment as a buffer - GET /db/id/attname - db.attachment.get', async () => {
+  // mocks
+  const json = JSON.stringify({ foo: 'bar' })
+  mockPool
+    .intercept({ path: '/db/id/att.json' })
+    .reply(200, json, { headers: { 'content-type': 'application/json' } })
+
+  // test GET /db/id/attname
+  const db = nano.db.use('db')
+  const p = await db.attachment.get('id', 'att.json')
+  assert(Buffer.isBuffer(p), 'JSON attachment should be a buffer')
+  assert.equal(p.toString(), json)
+  mockAgent.assertNoPendingInterceptors()
+})
+
 test('should detect missing parameters - db.attachment.get', async () => {
   const db = nano.db.use('db')
   await assert.rejects(db.attachment.get(), { message: 'Invalid parameters' })