Skip to content

"Advanced Client Search" is a single free-text box, offering nothing the global search does not #493

Description

@Aman-Mittal

What happens

/clients/search, presented in the sidebar as Advanced Client Search, renders exactly one control: a "Search Query" text input and a Search button.

document.querySelector('main').querySelectorAll('input, select, ion-select, ion-input, ion-checkbox, ion-datetime, textarea')
// → one ION-INPUT (plus its inner native input). No other control on the page.

The Advanced Client Search screen: a single "Search Query" field and a Search button, nothing else

Confirmed in source — src/app/features/clients/client-search-v2.component.ts declares a single <ion-input> and no other form control.

Why the naming is a problem

There are no filters for office, status, external ID, mobile number, activation date range, staff, legal form, or any other client attribute. A single free-text query is the same capability the global search at /search already provides, just scoped to clients.

So a user who deliberately picks "Advanced Client Search" over the plain Clients list — which does have a status filter and a search box — gets less than they started with, under a name that promises more. The label sets an expectation of targeted multi-field search that the screen does not meet.

Suggested fix

Either make it advanced or rename it. Making it advanced is the more useful direction, and the backend supports it: Fineract's client search accepts office, status, external ID, display name, mobile number and date filters, so this is a matter of surfacing fields that already have endpoints behind them.

A reasonable first cut:

  • Office (select, defaulting to the user's own)
  • Status (select)
  • External ID, mobile number (text)
  • Activation / submitted date range

If that is not near-term work, renaming the nav entry to something honest — "Client Search" — is a one-key change that stops the screen promising capability it does not have.

Environment

Verified against a clean checkout of main (a24a06ba) served with ng serve, backend sandbox.mifos.community, 1366×900, Chrome.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions