Repository navigation
[Cherry-pick to branch-1.3] [#13420] fix(core): Fix flaky TestJobManagerMultiNode.testCancelJobFromAnotherNode (#13460) - #13879
Merged
yuqi1129 merged 1 commit intoOct 15, 2026
Conversation
…lJobFromAnotherNode (apache#13460) ### What changes were proposed in this pull request? After node A's first status pull, accept either `CANCELLING` or `CANCELLED` as the stored status. The final assertions after the second pull (`CANCELLED` and `finishedAt > 0`) are unchanged. ### Why are the changes needed? `cancelOwnedJob` cancels the job and immediately reads its status back. If the local process exits before the read, the first pull already stores `CANCELLED`, so the test fails depending on timing. Fix: apache#13420 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? `./gradlew :core:test --tests TestJobManagerMultiNode -PskipITs` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Qi Yu <yuqi@datastrato.com> (cherry picked from commit c384d03)
Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Cherry-pick #13460 to branch-1.3. After node A's first status pull, accept either
CANCELLINGorCANCELLEDas the stored status. The final assertions after the second pull (CANCELLEDandfinishedAt > 0) are unchanged.Why are the changes needed?
cancelOwnedJobcancels the job and immediately reads its status back. If the local process exits before the read, the first pull already storesCANCELLED, so the test fails depending on timing. The flake still occurs on branch-1.3.Fix: #13420
Does this PR introduce any user-facing change?
No.
How was this patch tested?
./gradlew :core:test --tests TestJobManagerMultiNode -PskipITs(9 passed).