Repository navigation
Conversation
This was referenced Oct 15, 2026
lasdf1234
force-pushed
the
feature/tms-policy-peers-wire-13800
branch
from
October 15, 2026 12:15
20ec6e7 to
958f18c
Compare
lasdf1234
marked this pull request as draft
October 15, 2026 12:22
lasdf1234
force-pushed
the
feature/tms-policy-peers-wire-13800
branch
from
October 15, 2026 12:37
958f18c to
dcd7ef5
Compare
Code Coverage Report
Files
|
roryqi
pushed a commit
that referenced
this pull request
Oct 16, 2026
#13885) ### What changes were proposed in this pull request? Split from #13801 (1/2). **Domain** execution peers for Epic #13764 / #13800. - `PolicyExecutionSpec` / `ExecutablePolicyContent` / `PolicyExecutionFields` - Four Iceberg maintenance contents carry peers at construction - TMS design notes on peers / `BuiltInType` identity **Follow-up (stack):** #13888 / #13887 — wire/DTO/SerDe + `minIntervalMs` registry. ### Why are the changes needed? TMS needs shared trigger / cooldown / option-bag concepts without freezing them onto every `PolicyContent`. Fix: #13800 ### Does this PR introduce _any_ user-facing change? API/domain surface for optional peers on Iceberg maintenance contents (REST wire lands in #13887). ### How was this patch tested? ```bash ./gradlew :api:test --tests 'org.apache.gravitino.policy.*' -PskipITs ``` --------- Co-authored-by: Cursor <cursoragent@cursor.com>
lasdf1234
marked this pull request as ready for review
October 16, 2026 03:41
…efaults registry REST PolicyContentDTO accessors and DTOConverters for flat peers; BuiltInType minIntervalMs server defaults, conf template, and docs. Co-authored-by: Cursor <cursoragent@cursor.com>
…che#13885 fold Co-authored-by: Cursor <cursoragent@cursor.com>
lasdf1234
force-pushed
the
feature/tms-policy-peers-wire-13800
branch
from
October 16, 2026 03:50
dcd7ef5 to
ce91fa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Split from #13801 (2/2). Stack on #13885 (merge that first). Tracked by #13888.
Incremental scope (~1.5k vs #13885 ~1.1k):
ExecutablePolicyContentSerde+ IcebergPolicyContentDTO/DTOConvertersPOConvertersround-trips for each executable built-in typeMaintenancePolicyDefinitions+ per-typegravitino.maintenance.*.minIntervalMs+ conf/docsUntil #13885 merges, the GitHub file list includes domain files from the stack base; review the second commit /
common+core/maintenance+conf+docspaths.Why are the changes needed?
Preserve flat wire/persistence JSON without flattening Spec into every type; server defaults for omitted
minIntervalMs.Fix: #13888
Does this PR introduce any user-facing change?
Yes — optional JSON peer fields on Iceberg maintenance policy contents, and:
gravitino.maintenance.compaction.minIntervalMs(3600000)gravitino.maintenance.manifest-rewrite.minIntervalMs(3600000)gravitino.maintenance.snapshot-expiry.minIntervalMs(3600000)gravitino.maintenance.orphan-cleanup.minIntervalMs(86400000)How was this patch tested?