Repository navigation
Conversation
roryqi
reviewed
Oct 16, 2026
| View view = getViewCatalog().loadView(viewIdentifier); | ||
| Preconditions.checkState( | ||
| view instanceof BaseView, "Cannot wrap catalog that does not produce BaseView"); | ||
| ViewMetadata metadata = ((BaseView) view).operations().current(); |
Contributor
There was a problem hiding this comment.
Does table have the similar issue?
Contributor
Author
There was a problem hiding this comment.
No, I checked it, and the table works well.
Code Coverage Report
Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Build Iceberg load-view responses from a checked metadata snapshot. If a native rename removes the old view between the existence check and metadata read, throw
NoSuchViewExceptionwith the identifier instead of passing null metadata to the response builder.Why are the changes needed?
Iceberg 1.11 creates a fresh operations instance after checking view existence. A native rename in between can therefore turn a missing view into
NullPointerException: metadatarather than the normal not-found response.Fix: #13895
Does this PR introduce any user-facing change?
A view that disappears during loading produces a normal not-found error instead of an internal metadata NPE. Successful responses keep the same metadata and location fields.
How was this patch tested?
main(iceberg-common: 80, catalog-lakehouse-iceberg: 115, iceberg-rest-server: 466)../gradlew :iceberg:iceberg-common:spotlessCheck :iceberg:iceberg-common:test :catalogs:catalog-lakehouse-iceberg:test :iceberg:iceberg-rest-server:test -PskipITs -PskipDockerTests=truewithSKIP_DOCKER_TESTS=true.