Repository navigation
[#13980] fix(iceberg): Authorize table metrics reports - #13981
Merged
Merged
Conversation
yuqi1129
approved these changes
Oct 20, 2026
Code Coverage Report
Files
|
jerryshao
pushed a commit
that referenced
this pull request
Oct 21, 2026
…14043) ### What changes were proposed in this pull request? Backport #13981 to `branch-1.3`: authorize Iceberg REST table metrics reports, check that the table exists, and reject reports that name a different table. Keep local authorization for metrics submitted through a REST-backed catalog. The cherry-pick conflicts are resolved; request-cache code unavailable on `branch-1.3` was omitted. ### Why are the changes needed? An authenticated caller without table access could submit fabricated metrics because the report endpoint lacked an authorization expression. Fix: #13980 ### Does this PR introduce _any_ user-facing change? Unauthorized reports return 403, reports for missing tables return 404, and reports naming another table return 400. ### How was this patch tested? - Ran Spotless for `server-common` and `iceberg-rest-server`. - Passed `TestBaseMetadataAuthorizationMethodInterceptor`, `TestIcebergMetadataAuthorizationMethodInterceptor`, and `TestIcebergTableOperations.testReportTableMetrics`. --------- Co-authored-by: roryqi <roryqi@datastrato.com> Co-authored-by: roryqi <roryqi@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
An authenticated caller without table access could submit fabricated metrics because the report endpoint had no authorization annotation.
Fix: #13980
Does this PR introduce any user-facing change?
Unauthorized reports return 403. Reports for nonexistent tables return 404. Reports naming another table return 400.
How was this patch tested?
server-commonandiceberg-rest-server.TestBaseMetadataAuthorizationMethodInterceptor,TestIcebergMetadataAuthorizationMethodInterceptor, andTestIcebergTableOperations.testReportTableMetricswith Gradle; all passed.