Repository navigation
docs: clarify graph maintenance and client routing - #519
Conversation
- describe startup source recovery and failure retries - document local deletion protection across graph spaces - explain authentication and cache RPC reload limits
- align configuration references with startup sources - preserve reload protection and recovery boundaries - wrap the added prose to the repository line limit
- document overlapping reload rejection and retry - qualify closed graph cleanup and data boundaries - explain local task owner waits and forced cancellation
- merge current documentation master - align schema graph space routes with the Go client - preserve merged edge label and error guidance
- describe the manager lifecycle admission guard - retain explicit retry and notification boundaries - align the Chinese and English API guidance
- explain deferred remote graph removal notifications - include overlapping operations in reload error summary - distinguish local waiting from distributed task deletion
- require quiesced writes during deletion and retries - retain failed owners only for cleanup recovery - explain partial deletion and closed task admission
- describe local publication and notification coordination - retain quota and local configuration protection rules - prohibit same-name recreation during failed cleanup - document explicit recovery after replacement failures
- describe waiting behind an active lifecycle operation - state the wait has no configured timeout - distinguish interruption and immediate API rejection
- make file removal mandatory for reload and restart - explain retained files restore deletion protection - preserve the DEFAULT graph-space protection scope
- describe local task drain and manual maintenance - require restart for configuration changes - clarify uncertain cleanup and reload data risk - preserve existing Go schema routing guidance
- retain closed admission after task-drain refusal - wait for all task owners and cancellation cleanup - limit restart recovery to pre-destructive failures
- keep the configuration guide URI contiguous - preserve the existing FAQ explanation - verify the actual CommonMark link anchor
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The task-drain, reload and graph.load_from_local_config wording matches Server master after apache/hugegraph#3308, and the Go client GraphSpace routing matches toolchain master after apache/hugegraph-toolchain#799. One new recovery instruction, for a graph protected by local configuration, ends in a retry that fails when the graph exists only as a local properties file, and one table row differs between the English and Chinese config guide. Evidence: full diff 2d0b830...c9338d5 read on all 16 files; claims checked statically against GraphManager (reload, dropGraph, dropGraphLocal, loadGraph, init), StandardHugeGraph.drop and truncateBackend, StandardTaskScheduler and DistributedTaskScheduler (close, waitUntilAllTasksCompleted), GraphsAPI, CoreOptions.TASK_WAIT_TIMEOUT and ServerOptions.GRAPH_LOAD_FROM_LOCAL_CONFIG at apache/hugegraph master 0b7c0de3, and against the schema, propertykey, vertexlabel, edgelabel, vertex and gremlin code under api/v1 in hugegraph-client-go at toolchain master 8e6ed847. No Hugo build and no Server run were done for this review; the Build and deploy site check was still queued on this head.
中文说明 (Chinese Summary)
背景与目标
原文档对图维护(如删除图、动态重载)的保证超出了 Server 的实际实现。本 PR 结合 apache/hugegraph#3308 的任务排空(task-drain)与图删除机制,全面对齐中英文 API、配置、FAQ 及快速上手文档,并修正 Go 客户端的图空间路由。
主要改动
graphs.md,task.md,faq.md,hugegraph-server.md):hugegraph-client-go.md):config-guide.md,faq.md等):边界与注意事项
English Description
Summary
Align bilingual documentation with actual Server behavior regarding graph maintenance (task-drain & deletion) based on apache/hugegraph#3308, and fix Go client GraphSpace schema routing.
Key Changes
graphs.md,task.md,faq.md,hugegraph-server.md):hugegraph-client-go.md):config-guide.md,faq.md, etc.):Scope & Boundaries
Related Implementation PRs
Verification
dist/validate-links.sh)Conceptual Overview