Repository navigation
fix(server): release traversal worker leases - #3314
Merged
Merged
Conversation
- bind worker transactions before consuming lazy edge queries - release worker-owned backend leases on completion and failure - cover RocksDB lease cleanup and caller transaction boundaries
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3314 +/- ##
============================================
+ Coverage 52.24% 52.28% +0.03%
+ Complexity 2274 2272 -2
============================================
Files 762 762
Lines 67399 67400 +1
Branches 9138 9138
============================================
+ Hits 35211 35238 +27
+ Misses 28649 28622 -27
- Partials 3539 3540 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- cover bounded Kneighbor traversal with real RocksDB - reopen the original database with all column families - verify the actual capacity stop preserves caller work
This was referenced Oct 12, 2026
Pengzna
approved these changes
Oct 12, 2026
imbajin
added a commit
that referenced
this pull request
Oct 12, 2026
An OLTP edge consumer could leave its active iterator open after failure, early stop or interruption. A full queue could also keep its producer blocked after the worker failed, and a later transaction cleanup failure could replace the original business error. Close the owned iterator in finally, using the original input when preparation fails. Stop failed consumer queues so blocked producers can exit, propagate a normal stop so producers stop reading inputs, retain the first terminal error, and attach later cleanup failures as suppressed exceptions. Preserve the worker transaction binding and completion cleanup from #3314 while integrating current master and both native test registrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel traversals could leave a RocksDB worker session open after graph deletion, keeping files locked and preventing recreation at the same path. Bind the worker transaction before consuming lazy edge queries and release worker-owned transactions when consumers finish, including failure and early stop. Caller transactions remain intact.
The regressions cover real worker leases, actual capacity stops and caller transaction boundaries. A bounded Kneighbor traversal now checks that leases disappear, closes the graph while preserving its database, and immediately opens the original database and every column family with creation disabled.
Validation: the native regression fails with worker cleanup alone and passes with early transaction binding; removing the actual capacity-stop branch makes its dedicated regression fail. A separate small HTTP test verified Kneighbor results, graph deletion without remaining native handles, first same-path recreation and independent Unicode data readback. Java 17 formatting, clean reactor compilation, focused RocksDB tests and three independent reviews passed. The new source revision requires fresh CI.
Related release issue: SV10. This internal transaction lifecycle fix adds no API, configuration or dependency (
Doc - No Need). The original shared-service handle residue, complete C04, authenticated and distributed release acceptance remain open.Change diagram
Worker transaction binding and lease cleanup without closing caller transactions. This conceptual diagram does not replace the validation and scope notes above.
