Skip to content

fix(server): respect vertex graphspace permissions - #3315

Merged
imbajin merged 1 commit into
apache:masterfrom
hugegraph:fix/vertex-graphspace-permissions
Oct 12, 2026
Merged

imbajin merged 1 commit into
apache:masterfrom
hugegraph:fix/vertex-graphspace-permissions

Conversation

@imbajin

@imbajin imbajin commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Scoped users could access edges but were denied equivalent vertex operations in a GraphSpace. Six Vertex API permission declarations omitted the graphspace prefix, so the authorization filter could not interpret their graph and action requirements.

Add the missing scope to vertex creation, update, get and delete, matching the existing Edge API and vertex-list declarations. Existing admin/member behavior and space, graph and action restrictions remain intact.

Validation: the same real Jersey authorization-filter regression rejects the affected routes before the fix and passes afterward; cross-space, wrong-graph and insufficient-action requests still fail. Focused offline Maven tests, Java 17 formatting, clean reactor compilation and three independent reviews passed. Full authenticated HTTP and distributed deployment acceptance remain open.

Related release issue: SV11. This restores the existing permission contract without changing endpoints, payloads or configuration (Doc - No Need).

The source branch follows current ASF master. The org comparison also contains the already merged launcher baseline; the Vertex permission fix itself is limited to its API declarations and regression tests.

Change diagram

GraphSpace-aware Vertex API permission matching while preserving access restrictions. This conceptual diagram does not replace the validation and scope notes above.
GraphSpace-aware Vertex API permission matching while preserving access restrictions

- include graphspace in six vertex permission declarations
- verify real Jersey scoped authorization before and after
- preserve space, graph and action rejection boundaries
@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.29%. Comparing base (cfc5c23) to head (e2ea8ee).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3315      +/-   ##
============================================
+ Coverage     52.24%   52.29%   +0.05%     
+ Complexity     2274     2270       -4     
============================================
  Files           762      762              
  Lines         67399    67399              
  Branches       9138     9138              
============================================
+ Hits          35211    35248      +37     
+ Misses        28649    28604      -45     
- Partials       3539     3547       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@imbajin imbajin changed the title fix(api): respect vertex graphspace permissions fix(server): respect vertex graphspace permissions Oct 12, 2026
@imbajin
imbajin merged commit a247530 into apache:master Oct 12, 2026
33 checks passed
@imbajin
imbajin deleted the fix/vertex-graphspace-permissions branch October 12, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants