Repository navigation
fix(server): respect vertex graphspace permissions - #3315
Merged
imbajin merged 1 commit intoOct 12, 2026
Merged
Conversation
- include graphspace in six vertex permission declarations - verify real Jersey scoped authorization before and after - preserve space, graph and action rejection boundaries
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3315 +/- ##
============================================
+ Coverage 52.24% 52.29% +0.05%
+ Complexity 2274 2270 -4
============================================
Files 762 762
Lines 67399 67399
Branches 9138 9138
============================================
+ Hits 35211 35248 +37
+ Misses 28649 28604 -45
- Partials 3539 3547 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pengzna
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scoped users could access edges but were denied equivalent vertex operations in a GraphSpace. Six Vertex API permission declarations omitted the graphspace prefix, so the authorization filter could not interpret their graph and action requirements.
Add the missing scope to vertex creation, update, get and delete, matching the existing Edge API and vertex-list declarations. Existing admin/member behavior and space, graph and action restrictions remain intact.
Validation: the same real Jersey authorization-filter regression rejects the affected routes before the fix and passes afterward; cross-space, wrong-graph and insufficient-action requests still fail. Focused offline Maven tests, Java 17 formatting, clean reactor compilation and three independent reviews passed. Full authenticated HTTP and distributed deployment acceptance remain open.
Related release issue: SV11. This restores the existing permission contract without changing endpoints, payloads or configuration (
Doc - No Need).The source branch follows current ASF master. The org comparison also contains the already merged launcher baseline; the Vertex permission fix itself is limited to its API declarations and regression tests.
Change diagram
GraphSpace-aware Vertex API permission matching while preserving access restrictions. This conceptual diagram does not replace the validation and scope notes above.
