Repository navigation
fix(scan): apply equality deletes from an all-void partition spec globally - #3449
Draft
JeonDaehong wants to merge 1 commit into
Draft
JeonDaehong wants to merge 1 commit into
JeonDaehong wants to merge 1 commit into
Conversation
…bally A spec whose fields are all void transforms is unpartitioned, as PartitionSpec::is_unpartitioned and Java PartitionSpec.isUnpartitioned say. The delete file index only checked whether the partition tuple was empty, so equality deletes written under such a spec were indexed by a null partition and never matched data files from an earlier, partitioned spec.
Contributor
Author
|
@CTTY @mbutrovich could you take a look when you have time? Small fix in |
JeonDaehong
marked this pull request as draft
October 16, 2026 06:23
Contributor
Author
|
Converted to draft to stay within the new limit of 3 open PRs (#3465). The change is still ready for review; I will mark it ready again when one of my other PRs lands. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None, found while reading
DeleteFileIndex.What changes are included in this PR?
The spec says equality deletes stored with an unpartitioned spec are global. Java decides this with
spec.isUnpartitioned(), which is also true when every field is a void transform (what a v1 table keeps after dropping a partition field). Rust checked whether the partition tuple was empty, so such deletes were indexed under a[null]partition and never matched data files from the earlier, partitioned spec. Deleted rows came back.DeleteFileContextnow carries the delete file's spec, and the index usesPartitionSpec::is_unpartitioned. If the spec is missing, it falls back to the old check. Position deletes are unchanged: Java scopes them by spec and partition too.Are these changes tested?
Yes.
test_void_spec_equality_delete_is_globalfails onmain(0 deletes applied) and passes here.cargo test -p iceberg --lib, clippy and fmt are clean.AI Disclosure
I used Claude Code to find this, write the change and run the tests. I reviewed it before opening the PR.