Repository navigation
test(glue): cover KMS property forwarding - #3478
Merged
kevinjqliu merged 1 commit intoOct 16, 2026
Merged
Conversation
Record the full map received by the KMS factory and check initialization error propagation. Label missing and empty warehouse cases and document the crate-private Glue properties. Follow-up to apache#3102. Generated-by: Codex
comphead
approved these changes
Oct 16, 2026
comphead
left a comment
comphead
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @blackmwk makes sense
Btw you may consider AsRef interface
for
properties: &HashMap<impl AsRef<str>, impl AsRef<str>>
to avoid to_string() conversion everywhere
like
GLUE_CATALOG_PROP_URI.to_string(),
"http://localhost".to_string(),
kevinjqliu
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up to the review comments on #3102. Relates to #3096.
What changes are included in this PR?
Pin the contract that Glue forwards the full input map to its KMS factory, including URI, catalog ID, warehouse, and custom properties. A recording factory returns an error before AWS client initialization, covering both the property handoff and error propagation. Warehouse validation failures identify the missing or empty case.
The existing
GlueCatalogdebug output excludes the raw property map, so AWS secret keys and session tokens are no longer printed.Are these changes tested?
Using the pinned
nightly-2026-04-16toolchain:cargo test --locked -p iceberg-catalog-glue --lib— 20 passed.cargo clippy --locked -p iceberg-catalog-glue --all-targets -- -D warnings.cargo fmt --all -- --checkandgit diff --check.AI Disclosure
OpenAI Codex assisted with the tests and documentation. Review focus: the recording factory deliberately aborts initialization, so coverage is limited to the KMS property handoff and error propagation.