IGNITE-29056 Introduce snapshot lists command to control.sh by Vladsz83 · Pull Request #13666 · apache/ignite

Vladsz83 · 2026-10-08T11:18:17Z

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

There is a single JIRA ticket related to the pull request.
The web-link to the pull request is attached to the JIRA ticket.
The JIRA ticket has the Patch Available state.
The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see tab PR Check at TC.Bot - Instance 1 or TC.Bot - Instance 2)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

# Conflicts: # modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/IgniteSchema.java

…ommand

Copilot

🟡 Changes recommended

Unresolved critical feature-ID compatibility and moderate snapshot metadata validation findings remain.

1 open issue

Assign a unique feature ID for SNAPSHOT_LIST_FEATURE · New

What changed in this PR

Adds control.sh|bat --snapshot list to enumerate snapshots, metadata, sizes, incremental parts, and external storage usage.

Changes:

Adds snapshot-list commands, tasks, DTOs, and output formatting.
Adds feature gating, documentation, help updates, and extensive tests.
Updates snapshot metadata handling and test utilities.

File	Description
`modules/ducktests/src/main/java/org/apache/ignite/internal/ducktest/tests/ContinuousDataLoadApplication.java`	Corrects a typo.
`modules/core/src/test/resources/org.apache.ignite.util/GridCommandHandlerClusterByClassWithSSLTest_help.output`	Updates CLI help.
`modules/core/src/test/resources/org.apache.ignite.util/GridCommandHandlerClusterByClassTest_help.output`	Updates CLI help.
`modules/core/src/test/java/org/apache/ignite/testsuites/IgniteSnapshotTestSuite9.java`	Adds snapshot-list test suite.
`modules/core/src/test/java/org/apache/ignite/internal/processors/rollingupgrade/feature/TestIgniteReleaseFeatures_2_19_4.java`	Adds release feature definitions.
`modules/core/src/test/java/org/apache/ignite/internal/processors/rollingupgrade/AbstractRollingUpgradeTest.java`	Updates release feature coverage.
`modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/incremental/IncrementalSnapshotNodeFailureTest.java`	Updates snapshot manager access.
`modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/incremental/AbstractIncrementalSnapshotTest.java`	Updates snapshot manager access.
`modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotListTest.java`	Adds snapshot-list tests.
`modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotListRollingUpgradeTest.java`	Adds rolling-upgrade tests.
`modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/AbstractSnapshotSelfTest.java`	Generalizes snapshot helpers.
`modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/feature/CoreFeatureRegistry.java`	Registers the snapshot-list feature.
`modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageImpl.java`	Corrects a typo.
`modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotMetadataVerificationTask.java`	Adds TODO documentation.
`modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotListTaskResult.java`	Adds aggregate result DTO.
`modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotListJobResult.java`	Adds per-node result DTO.
`modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckProcess.java`	Corrects a typo.
`modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java`	Supports tolerant metadata reads.
`modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/filename/SnapshotFileTree.java`	Documents path limitations.
`modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsSingleMessage.java`	Corrects a typo.
`modules/core/src/main/java/org/apache/ignite/internal/management/snapshot/SnapshotListTask.java`	Implements snapshot discovery and sizing.
`modules/core/src/main/java/org/apache/ignite/internal/management/snapshot/SnapshotListCommandArg.java`	Adds the `--src` argument.
`modules/core/src/main/java/org/apache/ignite/internal/management/snapshot/SnapshotListCommand.java`	Formats command output.
`modules/core/src/main/java/org/apache/ignite/internal/management/snapshot/SnapshotCommand.java`	Registers the list subcommand.
`modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerListSnapshotTest.java`	Adds CLI tests.
`modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerAbstractTest.java`	Refactors test cache setup.
`modules/control-utility/src/test/java/org/apache/ignite/testsuites/IgniteControlUtilityTestSuite6.java`	Adds CLI test suite.
`docs/_docs/snapshots/snapshots.adoc`	Documents snapshot listing.

_{Review effort: Lite}

…s-command-to-control.sh' into IGNITE-29056-Introduce-snapshot-lists-command-to-control.sh

…and-to-control.sh # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/feature/CoreFeatureRegistry.java

…and-to-control.sh-dev # Conflicts: # docs/_docs/snapshots/snapshots.adoc # modules/control-utility/src/test/java/org/apache/ignite/testsuites/IgniteControlUtilityTestSuite6.java # modules/core/src/main/java/org/apache/ignite/internal/management/snapshot/SnapshotCommand.java # modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java # modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotMetadataVerificationTask.java # modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/feature/CoreFeatureRegistry.java # modules/core/src/test/java/org/apache/ignite/testsuites/IgniteSnapshotTestSuite9.java # modules/core/src/test/resources/org.apache.ignite.util/GridCommandHandlerClusterByClassTest_help.output # modules/core/src/test/resources/org.apache.ignite.util/GridCommandHandlerClusterByClassWithSSLTest_help.output

…l.sh-dev' into IGNITE-29056-Introduce-snapshot-lists-command-to-control.sh

…and-to-control.sh

zstan

Plz fix (or reply) last comments

zstan · 2026-10-26T07:53:06Z

+                int i0 = i;
+                int k0 = k;


redundant variables

zstan · 2026-10-26T08:28:19Z

+            ComputeJobResult nodeJobRes = nodesJobsResults.get(i);
+
+            if (nodeJobRes.getException() != null) {
+                throw new IgniteException("Failed to execute snapshot list job on node [uuid=" + nodeJobRes.getNode().id() + ']',


I`d prefer to fix it, but if other places are uses the same approach - it`s up to you

github-actions · 2026-10-26T13:33:55Z

Possible compatibility issues. Please, check rolling upgrade cases

This PR modifies protected classes (with Order annotation).
Changes to these classes can break rolling upgrade compatibility.

Affected files:

modules/core/src/main/java/org/apache/ignite/internal/management/snapshot/SnapshotCheckCommandArg.java
modules/core/src/main/java/org/apache/ignite/internal/management/snapshot/SnapshotDeleteCommandArg.java
modules/core/src/main/java/org/apache/ignite/internal/management/snapshot/SnapshotListCommandArg.java
modules/core/src/main/java/org/apache/ignite/internal/management/snapshot/SnapshotRestoreCommandArg.java
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotListJobResult.java
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotListTaskResult.java

Vladsz83 and others added 30 commits September 7, 2026 19:39

neuroslop

eb6273c

IGNITE-29037 Refactored Message Factory usage in TCP Discovery implem…

d9aa470

…entations (apache#13551)

raw

7042aec

raw

682a21c

Merge branch 'master' into support-snapshot-lists

bcc72c4

raw

3ab443a

raw

9171c7e

+ snpPath

de68328

better tests

f0996e9

own test

80c7644

Merge branch 'master' into snp-delete

c8d1c25

# Conflicts: # modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/IgniteSchema.java

+ test

fc11a5f

Simplification

8a007e3

+ restore test

97ab26c

+ create test

fbb2cf8

reimpl tests

2ed26ad

better IgniteClusterSnapshotDeleteTest

9b0e5ff

+incr test

b09e0b3

raw

71717c2

+ feature support test

7148da6

+ IgniteClusterSnapshotDeleteTest

d36c642

fix

9a658df

Merge branch 'master' into Introduce-snapshot-deletion-command

35a4c9d

test fix + doc

d715c66

+ RU test. + many small fixes.

e6aa330

review fixes

4233322

test fix

b11f389

Merge branch 'master' into IGNITE-29050-Introduce-snapshot-deletion-c…

37cb071

…ommand

+ tests

f00d266

+ tests

57909f4

Copilot AI reviewed Oct 19, 2026

View reviewed changes

Comment thread ...n/java/org/apache/ignite/internal/processors/rollingupgrade/feature/CoreFeatureRegistry.java Outdated

zstan reviewed Oct 19, 2026

View reviewed changes

Vladsz83 added 20 commits October 20, 2026 12:12

Merge remote-tracking branch 'my/IGNITE-29056-Introduce-snapshot-list…

3326b00

…s-command-to-control.sh' into IGNITE-29056-Introduce-snapshot-lists-command-to-control.sh

Merge branch 'master' into IGNITE-29056-Introduce-snapshot-lists-comm…

f6e5e54

…and-to-control.sh # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/feature/CoreFeatureRegistry.java

RU test improvement. + master. Review fixes

1efded3

RU test improvement. + master. Review fixes

eeaa3ce

1st test simplification

ad5e558

2nd test simplification

60d5152

test fixes

e270339

LLM review fixes

deb6b7e

Merge branch 'master' into IGNITE-29056-Introduce-snapshot-lists-comm…

6111849

…and-to-control.sh # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/feature/CoreFeatureRegistry.java

review fixes: the cancellation fix

260453b

+ master, checkstyle

343d048

+ master, checkstyle, + the order test, formats

10625b0

+ master, checkstyle, + the order test, formats

d0f3212

Merge branch 'IGNITE-29056-Introduce-snapshot-lists-command-to-contro…

dc81b62

…l.sh-dev' into IGNITE-29056-Introduce-snapshot-lists-command-to-control.sh

table in progress

053b464

Fixes

a293b07

LLM revierw fixes

3a07483

Merge branch 'master' into IGNITE-29056-Introduce-snapshot-lists-comm…

d46a66e

…and-to-control.sh

fix

3447a5b

zstan reviewed Oct 26, 2026

View reviewed changes

Vladsz83 added 3 commits October 26, 2026 12:46

review fixes

24b88df

+ separated node errors processing, + test, -test (duplicate)

e96197d

Better exception processing

eb448e4

zstan approved these changes Oct 26, 2026

View reviewed changes

zstan merged commit 69e3a7c into apache:master Oct 27, 2026
6 checks passed

Vladsz83 deleted the IGNITE-29056-Introduce-snapshot-lists-command-to-control.sh branch October 27, 2026 08:11

Conversation

Vladsz83 commented Oct 8, 2026

The Contribution Checklist

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zstan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zstan Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

Vladsz83 Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zstan Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 26, 2026

Possible compatibility issues. Please, check rolling upgrade cases

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants