[rezataroosheh]

What

A local IndexQuery (setLocal(true)) on a cache that is not in keep-binary mode now returns deserialized keys and values, the same as the distributed query. Queries through withKeepBinary() still return BinaryObjects.

Why

IndexQueryProcessor#queryLocal always returns rows in binary form. On the distributed path, the query future converts them using the query's keepBinary flag (GridCacheQueryFutureAdapter#unwrapIfNeeded). The local path (GridCacheQueryManager#indexQueryLocal) skipped that step, so a typed read of a local result failed with ClassCastException. It was reported on the dev list.

The fix applies the same unwrapBinaryIfNeeded(..., qry.keepBinary(), ...) call in indexQueryLocal. IndexQueryProcessor is not changed, because it also serves the remote side of distributed queries.

Compatibility: code that reads local results of a non-keep-binary cache as BinaryObject will now get the cache's own classes. Such code can use withKeepBinary(), which keeps the binary form.

Note: this touches the same method as #13735 (IGNITE-29191), so whichever is merged second needs a small rebase.

Tests

New tests in IndexQueryLocalTest:

• testLocalQueryReturnsDeserializedValues: a local query on a non-keep-binary cache returns Person values. It fails without the fix (the values are BinaryObjects).
• testLocalQueryKeepBinaryReturnsBinaryValues: a local query through withKeepBinary() still returns BinaryObjects.

The Contribution Checklist

• There is a single JIRA ticket related to the pull request.
• The web-link to the pull request is attached to the JIRA ticket.
• The JIRA ticket has the Patch Available state.
• The pull request body describes changes that have been made.
  The description explains WHAT and WHY was made instead of HOW.
• The pull request title is treated as the final commit message.
  The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
• A reviewer has been mentioned through the JIRA comments
  (see the Maintainers list)
• The pull request has been checked by the Teamcity Bot and
  the green visa attached to the JIRA ticket (see tab PR Check at TC.Bot - Instance 1 or TC.Bot - Instance 2)

Notes

• How to Contribute
• Coding abbreviation rules
• Coding Guidelines
• Apache Ignite Teamcity Bot

If you need any help, please email dev@ignite.apache.org or ask any advice on https://the-asf.slack.com #ignite channel.

[timoninmaxim]

This test don't check binary key. Long should be replaced with POJO

[rezataroosheh]

Thanks! Replaced the Long key with a PersonId POJO. Both tests now check the key and the value: the first checks that they deserialize; the keep-binary one checks that they come back as BinaryObject.

[timoninmaxim]

Key/Value can be unwrap separately to avoid allocation of an additional tuple.

[rezataroosheh]

Done. The key and value are now unwrapped separately and passed directly to CacheEntryImpl, so no extra tuple is created.