Reuse DataRegion insert lock for IoTConsensus shutdown fencing (#18893)

Author: Caideyipi

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/consensus/statemachine/dataregion/DataExecutionVisitor.java

@@ -78,7 +78,6 @@ public TSStatus visitRelationalInsertRows(RelationalInsertRowsNode node, DataReg
   public TSStatus visitInsertRow(InsertRowNode node, DataRegion dataRegion) {
     try {
       dataRegion.insert(node);
-      dataRegion.insertSeparatorToWAL(node);
       return StatusUtils.OK;
     } catch (OutOfTTLException e) {
       LOGGER.warn(DataNodeMiscMessages.ERROR_EXECUTING_PLAN_NODE_CAUSED, node, e.getMessage());
@@ -104,7 +103,6 @@ public TSStatus visitRelationalInsertTablet(
   public TSStatus visitInsertTablet(final InsertTabletNode node, final DataRegion dataRegion) {
     try {
       dataRegion.insertTablet(node);
-      dataRegion.insertSeparatorToWAL(node);
       return StatusUtils.OK;
     } catch (final OutOfTTLException e) {
       LOGGER.debug(DataNodeMiscMessages.ERROR_EXECUTING_PLAN_NODE_CAUSED, node, e.getMessage());
@@ -144,7 +142,6 @@ public TSStatus visitInsertTablet(final InsertTabletNode node, final DataRegion
   public TSStatus visitInsertRows(InsertRowsNode node, DataRegion dataRegion) {
     try {
       dataRegion.insert(node);
-      dataRegion.insertSeparatorToWAL(node);
       return StatusUtils.OK;
     } catch (WriteProcessRejectException e) {
       LOGGER.warn(DataNodeMiscMessages.REJECT_EXECUTING_PLAN_NODE, node, e.getMessage());
@@ -184,7 +181,6 @@ public TSStatus visitInsertRows(InsertRowsNode node, DataRegion dataRegion) {
   public TSStatus visitInsertMultiTablets(InsertMultiTabletsNode node, DataRegion dataRegion) {
     try {
       dataRegion.insertTablets(node);
-      dataRegion.insertSeparatorToWAL(node);
       return StatusUtils.OK;
     } catch (WriteProcessRejectException e) {
       LOGGER.warn(DataNodeMiscMessages.REJECT_EXECUTING_PLAN_NODE, node, e.getMessage());
@@ -222,7 +218,6 @@ public TSStatus visitInsertRowsOfOneDevice(
       InsertRowsOfOneDeviceNode node, DataRegion dataRegion) {
     try {
       dataRegion.insert(node);
-      dataRegion.insertSeparatorToWAL(node);
       return StatusUtils.OK;
     } catch (WriteProcessRejectException e) {
       LOGGER.warn(DataNodeMiscMessages.REJECT_EXECUTING_PLAN_NODE, node, e.getMessage());
@@ -284,6 +279,8 @@ public TSStatus visitDeleteData(DeleteDataNode node, DataRegion dataRegion) {
       }
       dataRegion.insertSeparatorToWAL(node);
       return StatusUtils.OK;
+    } catch (WriteProcessRejectException e) {
+      return RpcUtils.getStatus(e.getErrorCode(), e.getMessage());
     } catch (IOException | IllegalPathException e) {
       LOGGER.error(DataNodeMiscMessages.ERROR_EXECUTING_PLAN_NODE, node, e);
       return new TSStatus(TSStatusCode.WRITE_PROCESS_ERROR.getStatusCode());
@@ -297,8 +294,9 @@ public TSStatus visitDeleteData(
       final RelationalDeleteDataNode node, final DataRegion dataRegion) {
     try {
       dataRegion.deleteByTable(node);
-      dataRegion.insertSeparatorToWAL(node);
       return StatusUtils.OK;
+    } catch (final WriteProcessRejectException e) {
+      return RpcUtils.getStatus(e.getErrorCode(), e.getMessage());
     } catch (final IOException e) {
       LOGGER.error(DataNodeMiscMessages.ERROR_EXECUTING_PLAN_NODE, node, e);
       return new TSStatus(TSStatusCode.WRITE_PROCESS_ERROR.getStatusCode());

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/consensus/statemachine/dataregion/DataRegionStateMachine.java

@@ -251,7 +251,7 @@ protected TSStatus write(PlanNode planNode) {
     TSStatus result = null;
     int retryTime = 0;
     while (retryTime < MAX_WRITE_RETRY_TIMES) {
-      result = executeWrite(planNode);
+      result = planNode.accept(new DataExecutionVisitor(), region);
       // Let pipe retry with the original event instead of retrying a possibly mutated node here.
       if (needRetryForSpecificCases(result.getCode(), planNode)) {
         retryTime++;
@@ -284,10 +284,6 @@ protected TSStatus write(PlanNode planNode) {
     return result;
   }
 
-  protected TSStatus executeWrite(PlanNode planNode) {
-    return planNode.accept(new DataExecutionVisitor(), region);
-  }
-
   protected void waitBeforeNextWriteRetry() throws InterruptedException {
     Thread.sleep(WRITE_RETRY_WAIT_TIME_IN_MS);
   }

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/consensus/statemachine/dataregion/IoTConsensusDataRegionStateMachine.java

@@ -50,13 +50,6 @@ public IoTConsensusDataRegionStateMachine(DataRegion region) {
     super(region);
   }
 
-  @Override
-  protected TSStatus executeWrite(PlanNode planNode) {
-    final DataRegion targetRegion = region;
-    return targetRegion.executeIoTConsensusWrite(
-        () -> planNode.accept(new DataExecutionVisitor(), targetRegion));
-  }
-
   @Override
   public TSStatus write(IConsensusRequest request) {
     try {