Skip to content

[To dev/1.3] Pipe: Further reduced the repeating exception log & Changed the default log reducer size to 16M (#16417) #16423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Caideyipi merged 2 commits into from
Sep 16, 2025
Merged

[To dev/1.3] Pipe: Further reduced the repeating exception log & Changed the default log reducer size to 16M (#16417) #16423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b58b4b0
Pipe: Further reduced the repeating exception log & Changed the defau…
Caideyipi Sep 15, 2025
5bf22ae
add-back
Caideyipi Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...in/java/org/apache/iotdb/db/pipe/sink/protocol/thrift/async/IoTDBDataRegionAsyncSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.apache.iotdb.commons.client.async.AsyncPipeDataTransferServiceClient;
import org.apache.iotdb.commons.pipe.config.PipeConfig;
import org.apache.iotdb.commons.pipe.event.EnrichedEvent;
import org.apache.iotdb.commons.pipe.resource.log.PipeLogger;
import org.apache.iotdb.commons.pipe.sink.protocol.IoTDBSink;
import org.apache.iotdb.db.pipe.event.common.heartbeat.PipeHeartbeatEvent;
import org.apache.iotdb.db.pipe.event.common.schema.PipeSchemaRegionWritePlanEvent;
Expand Down Expand Up @@ -497,11 +498,13 @@ public void updateLeaderCache(final String deviceId, final TEndPoint endPoint) {
private void logOnClientException(
final AsyncPipeDataTransferServiceClient client, final Exception e) {
if (client == null) {
LOGGER.warn(THRIFT_ERROR_FORMATTER_WITHOUT_ENDPOINT);
PipeLogger.log(LOGGER::warn, THRIFT_ERROR_FORMATTER_WITHOUT_ENDPOINT);
} else {
client.resetMethodStateIfStopped();
LOGGER.warn(
String.format(THRIFT_ERROR_FORMATTER_WITH_ENDPOINT, client.getIp(), client.getPort()), e);
PipeLogger.log(
LOGGER::warn,
e,
String.format(THRIFT_ERROR_FORMATTER_WITH_ENDPOINT, client.getIp(), client.getPort()));
}
}

Expand Down
2 changes: 1 addition & 1 deletion iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/conf/CommonConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ public class CommonConfig {
private int pipeReceiverReqDecompressedMaxLengthInBytes = 1073741824; // 1GB
private boolean pipeReceiverLoadConversionEnabled = false;
private volatile long pipePeriodicalLogMinIntervalSeconds = 60;
private volatile long pipeLoggerCacheMaxSizeInBytes = 10 * MB;
private volatile long pipeLoggerCacheMaxSizeInBytes = 16 * MB;

private volatile double pipeMetaReportMaxLogNumPerRound = 0.1;
private volatile int pipeMetaReportMaxLogIntervalRounds = 360;
Expand Down