Skip to content

Fixed multiple configNode bugs #17609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Caideyipi wants to merge 15 commits into
base: master
Choose a base branch
from
+1,162 −141
Open

Fixed multiple configNode bugs #17609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2047d3a
Fixed multiple config bugs
Caideyipi May 6, 2026
1d9fe36
fix
Caideyipi May 22, 2026
3e7536e
Merge branch 'master' of https://github.com/apache/iotdb into config-bug
Caideyipi May 22, 2026
1b86d98
fix
Caideyipi May 22, 2026
2e4c652
Update ConfigRegionStateMachine.java
Caideyipi May 22, 2026
cddb4b1
Address ConfigNode review feedback
Caideyipi Jun 3, 2026
65ae336
Merge remote-tracking branch 'origin/master' into config-bug
Caideyipi Jun 3, 2026
86aa613
Merge remote-tracking branch 'origin/master' into tmp/resolve-pr-17609
Caideyipi Jun 29, 2026
c39aed2
Fix compile
Caideyipi Jul 3, 2026
82cbdb2
Merge branch 'master' of https://github.com/apache/iotdb into config-bug
Caideyipi Jul 7, 2026
bfc80d6
Compile fix
Caideyipi Jul 7, 2026
f4b0fa4
Merge master into config-bug
Caideyipi Jul 30, 2026
a12b657
Fix NodeManager Sonar issues
Caideyipi Jul 31, 2026
03b8d95
Merge origin/master into config-bug
Caideyipi Oct 15, 2026
1e1ffe0
Fix ConfigNode WAL recovery and registration review feedback
Caideyipi Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions ...core/confignode/src/main/i18n/en/org/apache/iotdb/confignode/i18n/ConfigNodeMessages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,31 @@
package org.apache.iotdb.confignode.i18n;

public final class ConfigNodeMessages {
public static final String EXCEPTION_CONFIGNODE_SIMPLECONSENSUS_WRITES_ARE_DISABLED_AFTER_A_WAL_CLEANUP_FAILURE_RESTART_IS_REQUIRED_D52F0107 =
"ConfigNode SimpleConsensus writes are disabled after a WAL cleanup failure; restart is required.";
public static final String EXCEPTION_FAILED_TO_CLOSE_THE_CONFIGNODE_SIMPLECONSENSUS_LOG_WRITER_BC0F417C =
"Failed to close the ConfigNode SimpleConsensus log writer.";
public static final String EXCEPTION_FAILED_TO_APPLY_CONFIGNODE_ARG_THROUGH_CONSENSUS_LAYER_ARG_B4A985D7 =
"Failed to apply ConfigNode %s through consensus layer: %s";
public static final String EXCEPTION_FAILED_TO_PERSIST_VERSION_INFO_FOR_CONFIGNODE_ARG_ARG_REGISTRATION_REMAINS_PENDING_AND_MUST_BE_RETRIED_F662C350 =
"Failed to persist version info for ConfigNode %d: %s. Registration remains pending and must be retried.";
public static final String MESSAGE_UNKNOWN_ERROR_E9EEAFF8 =
"unknown error";
public static final String MESSAGE_STATUS_CODE_ARG_4B3BCD8B =
"status code %d";
public static final String MESSAGE_FAILED_TO_PERSIST_VERSION_INFO_FOR_DATANODE_ARG_ARG_THE_REGISTRATION_HAS_BEEN_ROLLED_BACK_PLEASE_RETRY_THE_REGISTRATION_5DDB311F =
"Failed to persist version info for DataNode %d: %s. The registration has been rolled back. Please retry the registration.";
public static final String MESSAGE_FAILED_TO_PERSIST_VERSION_INFO_FOR_DATANODE_ARG_ARG_THE_REGISTRATION_ROLLBACK_ALSO_FAILED_ARG_MANUAL_CLEANUP_MAY_BE_REQUIRED_BEFORE_RETRYING_THE_REGISTRATION_5463B5FF =
"Failed to persist version info for DataNode %d: %s. The registration rollback also failed: %s. Manual cleanup may be required before retrying the registration.";
public static final String LOG_FAILED_TO_ROLL_BACK_DATANODE_REGISTRATION_ARG_AFTER_VERSION_INFO_PERSISTENCE_FAILURE_VERSIONUPDATESTATUS_ARG_ROLLBACKSTATUS_ARG_437E6F09 =
"Failed to roll back DataNode registration {} after version info persistence failure. versionUpdateStatus: {}, rollbackStatus: {}";
public static final String MESSAGE_FAILED_TO_PERSIST_VERSION_INFO_FOR_AINODE_ARG_ARG_THE_REGISTRATION_HAS_BEEN_ROLLED_BACK_PLEASE_RETRY_THE_REGISTRATION_7571C626 =
"Failed to persist version info for AINode %d: %s. The registration has been rolled back. Please retry the registration.";
public static final String MESSAGE_FAILED_TO_PERSIST_VERSION_INFO_FOR_AINODE_ARG_ARG_THE_REGISTRATION_ROLLBACK_ALSO_FAILED_ARG_MANUAL_CLEANUP_MAY_BE_REQUIRED_BEFORE_RETRYING_THE_REGISTRATION_B9B1DCCD =
"Failed to persist version info for AINode %d: %s. The registration rollback also failed: %s. Manual cleanup may be required before retrying the registration.";
public static final String LOG_FAILED_TO_ROLL_BACK_AINODE_REGISTRATION_ARG_AFTER_VERSION_INFO_PERSISTENCE_FAILURE_VERSIONUPDATESTATUS_ARG_ROLLBACKSTATUS_ARG_BFF24BD4 =
"Failed to roll back AINode registration {} after version info persistence failure. versionUpdateStatus: {}, rollbackStatus: {}";

public static final String
EXCEPTION_FAILED_TO_CREATE_OR_ALTER_TOPIC_ILLEGAL_ARG_ARG_EXPECTED_A_LONG_VALUE_IN_MILLISECONDS_F79736B2 =
"Failed to create or alter topic, illegal %s=%s, expected a long value in milliseconds";
Expand Down Expand Up @@ -61,6 +86,18 @@ public final class ConfigNodeMessages {
"[ConfigRegion Update] Can't force logWriter for ConfigNode SimpleConsensus mode";
public static final String CAN_T_SERIALIZE_CURRENT_CONFIGPHYSICALPLAN_FOR_CONFIGNODE_SIMPLECONSENSUS_MODE =
"[ConfigRegion Update] Can't serialize current ConfigPhysicalPlan for ConfigNode SimpleConsensus mode";
public static final String PERSIST_CONFIGNODE_SIMPLECONSENSUS_LOG_FAILED =
"Persist ConfigNode SimpleConsensus log failed: %s";
public static final String PERSIST_CURRENT_CONFIGPHYSICALPLAN_FOR_CONFIGNODE_SIMPLECONSENSUS_MODE_FAILED =
"Persist current ConfigPhysicalPlan for ConfigNode SimpleConsensus mode failed";
public static final String FAILED_TO_ROLLBACK_PERSISTED_CONFIGNODE_SIMPLECONSENSUS_LOG =
"Failed to rollback persisted ConfigNode SimpleConsensus log. The persisted plan may be replayed after restart. Further SimpleConsensus writes are disabled until restart.";
public static final String ROLLBACK_FAILED_CONFIGPHYSICALPLAN_FOR_CONFIGNODE_SIMPLECONSENSUS_MODE_FAILED =
"Rollback failed ConfigPhysicalPlan for ConfigNode SimpleConsensus mode failed, planType: {}, logFile: {}, truncateOffset: {}, endIndexBeforeWrite: {}. Further SimpleConsensus writes are disabled until restart.";
public static final String SEAL_RECOVERED_CONFIGNODE_SIMPLECONSENSUS_LOG_FAILED =
"Seal recovered ConfigNode SimpleConsensus log failed: {}";
public static final String SIMPLECONSENSUS_LOG_WRITER_IS_NOT_INITIALIZED =
"SimpleConsensus log writer is not initialized.";
public static final String CAN_T_START_CONFIGNODE_CONSENSUS_GROUP =
"Can't start ConfigNode consensus group!";
public static final String CHANGE_REGIONS_LEADER_ERROR_ON_DATE_NODE =
Expand Down
45 changes: 41 additions & 4 deletions ...core/confignode/src/main/i18n/zh/org/apache/iotdb/confignode/i18n/ConfigNodeMessages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,31 @@
package org.apache.iotdb.confignode.i18n;

public final class ConfigNodeMessages {
public static final String EXCEPTION_CONFIGNODE_SIMPLECONSENSUS_WRITES_ARE_DISABLED_AFTER_A_WAL_CLEANUP_FAILURE_RESTART_IS_REQUIRED_D52F0107 =
"ConfigNode SimpleConsensus 因 WAL 清理失败已禁用写入，需要重启。";
public static final String EXCEPTION_FAILED_TO_CLOSE_THE_CONFIGNODE_SIMPLECONSENSUS_LOG_WRITER_BC0F417C =
"关闭 ConfigNode SimpleConsensus 日志写入器失败。";
public static final String EXCEPTION_FAILED_TO_APPLY_CONFIGNODE_ARG_THROUGH_CONSENSUS_LAYER_ARG_B4A985D7 =
"通过共识层应用 ConfigNode %s 失败：%s";
public static final String EXCEPTION_FAILED_TO_PERSIST_VERSION_INFO_FOR_CONFIGNODE_ARG_ARG_REGISTRATION_REMAINS_PENDING_AND_MUST_BE_RETRIED_F662C350 =
"持久化 ConfigNode %d 的版本信息失败：%s。注册尚未完成，需要重试。";
public static final String MESSAGE_UNKNOWN_ERROR_E9EEAFF8 =
"未知错误";
public static final String MESSAGE_STATUS_CODE_ARG_4B3BCD8B =
"状态码 %d";
public static final String MESSAGE_FAILED_TO_PERSIST_VERSION_INFO_FOR_DATANODE_ARG_ARG_THE_REGISTRATION_HAS_BEEN_ROLLED_BACK_PLEASE_RETRY_THE_REGISTRATION_5DDB311F =
"持久化 DataNode %d 的版本信息失败：%s。注册已回滚，请重试注册。";
public static final String MESSAGE_FAILED_TO_PERSIST_VERSION_INFO_FOR_DATANODE_ARG_ARG_THE_REGISTRATION_ROLLBACK_ALSO_FAILED_ARG_MANUAL_CLEANUP_MAY_BE_REQUIRED_BEFORE_RETRYING_THE_REGISTRATION_5463B5FF =
"持久化 DataNode %d 的版本信息失败：%s。注册回滚也失败：%s。重试注册前可能需要手动清理。";
public static final String LOG_FAILED_TO_ROLL_BACK_DATANODE_REGISTRATION_ARG_AFTER_VERSION_INFO_PERSISTENCE_FAILURE_VERSIONUPDATESTATUS_ARG_ROLLBACKSTATUS_ARG_437E6F09 =
"版本信息持久化失败后，回滚 DataNode {} 的注册失败。versionUpdateStatus: {}，rollbackStatus: {}";
public static final String MESSAGE_FAILED_TO_PERSIST_VERSION_INFO_FOR_AINODE_ARG_ARG_THE_REGISTRATION_HAS_BEEN_ROLLED_BACK_PLEASE_RETRY_THE_REGISTRATION_7571C626 =
"持久化 AINode %d 的版本信息失败：%s。注册已回滚，请重试注册。";
public static final String MESSAGE_FAILED_TO_PERSIST_VERSION_INFO_FOR_AINODE_ARG_ARG_THE_REGISTRATION_ROLLBACK_ALSO_FAILED_ARG_MANUAL_CLEANUP_MAY_BE_REQUIRED_BEFORE_RETRYING_THE_REGISTRATION_B9B1DCCD =
"持久化 AINode %d 的版本信息失败：%s。注册回滚也失败：%s。重试注册前可能需要手动清理。";
public static final String LOG_FAILED_TO_ROLL_BACK_AINODE_REGISTRATION_ARG_AFTER_VERSION_INFO_PERSISTENCE_FAILURE_VERSIONUPDATESTATUS_ARG_ROLLBACKSTATUS_ARG_BFF24BD4 =
"版本信息持久化失败后，回滚 AINode {} 的注册失败。versionUpdateStatus: {}，rollbackStatus: {}";

public static final String
EXCEPTION_FAILED_TO_CREATE_OR_ALTER_TOPIC_ILLEGAL_ARG_ARG_EXPECTED_A_LONG_VALUE_IN_MILLISECONDS_F79736B2 =
"创建或修改 topic 失败，%s=%s 无效，需指定以毫秒为单位的 long 值";
Expand Down Expand Up @@ -57,10 +82,22 @@ public final class ConfigNodeMessages {
"[ConfigRegion Update] 无法为 ConfigNode flushWALForSimpleConsensus 强制写入 logWriter";
public static final String CAN_T_FORCE_LOGWRITER_FOR_CONFIGNODE_SIMPLECONSENSUS_MODE =
"[ConfigRegion Update] 无法为 ConfigNode SimpleConsensus 模式强制写入 logWriter";
public static final String
CAN_T_SERIALIZE_CURRENT_CONFIGPHYSICALPLAN_FOR_CONFIGNODE_SIMPLECONSENSUS_MODE =
"[ConfigRegion Update] 无法为 ConfigNode SimpleConsensus 模式序列化当前 ConfigPhysicalPlan";
public static final String CAN_T_START_CONFIGNODE_CONSENSUS_GROUP = "无法启动 ConfigNode 共识组！";
public static final String CAN_T_SERIALIZE_CURRENT_CONFIGPHYSICALPLAN_FOR_CONFIGNODE_SIMPLECONSENSUS_MODE =
"[ConfigRegion Update] 无法为 ConfigNode SimpleConsensus 模式序列化当前 ConfigPhysicalPlan";
public static final String PERSIST_CONFIGNODE_SIMPLECONSENSUS_LOG_FAILED =
"持久化 ConfigNode SimpleConsensus 日志失败：%s";
public static final String PERSIST_CURRENT_CONFIGPHYSICALPLAN_FOR_CONFIGNODE_SIMPLECONSENSUS_MODE_FAILED =
"为 ConfigNode SimpleConsensus 模式持久化当前 ConfigPhysicalPlan 失败";
public static final String FAILED_TO_ROLLBACK_PERSISTED_CONFIGNODE_SIMPLECONSENSUS_LOG =
"回滚已持久化的 ConfigNode SimpleConsensus 日志失败。该 plan 可能会在重启后被重放。重启前将禁止后续 SimpleConsensus 写入。";
public static final String ROLLBACK_FAILED_CONFIGPHYSICALPLAN_FOR_CONFIGNODE_SIMPLECONSENSUS_MODE_FAILED =
"回滚 ConfigNode SimpleConsensus 模式下失败的 ConfigPhysicalPlan 失败，planType: {}, logFile: {}, truncateOffset: {}, endIndexBeforeWrite: {}。重启前将禁止后续 SimpleConsensus 写入。";
public static final String SEAL_RECOVERED_CONFIGNODE_SIMPLECONSENSUS_LOG_FAILED =
"封存恢复出的 ConfigNode SimpleConsensus 日志失败：{}";
public static final String SIMPLECONSENSUS_LOG_WRITER_IS_NOT_INITIALIZED =
"SimpleConsensus log writer 未初始化。";
public static final String CAN_T_START_CONFIGNODE_CONSENSUS_GROUP =
"无法启动 ConfigNode 共识组！";
public static final String CHANGE_REGIONS_LEADER_ERROR_ON_DATE_NODE =
"在 DataNode: {} 上切换 region leader 失败";
public static final String CHECK_BEFORE_DROPPING_TOPIC_TOPIC_EXISTS =
Expand Down
Loading
Loading