Skip to content

Pipe: Fix TsFile reference races and improve result set diffs (#18376) - #18602

Merged
JackieTien97 merged 1 commit into
rc/1.3.8from
to-138
Sep 9, 2026
Merged

JackieTien97 merged 1 commit into
rc/1.3.8from
to-138

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

#18544)

* Pipe: Fix concurrent TsFile reference increases

* Test: show concise result set diffs

* Pipe: Roll back failed TsFile reference increases

* Clarify nullable pipe resource map lookup
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.48%. Comparing base (ac360ca) to head (eed80fd).

Files with missing lines Patch % Lines
...ipe/resource/tsfile/PipeTsFileResourceManager.java 91.30% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             rc/1.3.8   #18602   +/-   ##
===========================================
  Coverage       44.47%   44.48%           
  Complexity        198      198           
===========================================
  Files            3641     3641           
  Lines          246688   246700   +12     
  Branches        30305    30307    +2     
===========================================
+ Hits           109722   109733   +11     
- Misses         136966   136967    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JackieTien97
JackieTien97 merged commit 98965cc into rc/1.3.8 Sep 9, 2026
16 of 25 checks passed
@JackieTien97
JackieTien97 deleted the to-138 branch September 9, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants