Repository navigation
[Test] Stabilize table DDL HA tests for async DROP TABLE - #18852
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #18806 made
DROP TABLEasynchronous,IoTDBTableDDLHAITstill checkedSHOW TABLESimmediately after submission. Both the stopped-DataNode and read-only-DataNode cases can fail while the drop procedure is still running.Wait up to 60 seconds for the latest matching procedure in
information_schema.drop_table_proceduresto reachSUCCESS, then retain the table-absence assertion before dropping the database. Retry transient inconsistencies between cluster progress snapshots while waiting, and include the procedure error message in the state assertion.Validation
git diff --checkpassed.IoTDBTableDDLHAITpassed locally inTableClusterITmode on JDK 17: 2 tests, 0 failures, 0 errors, 0 skipped. Both the stopped-DataNode and read-only-DataNode scenarios passed; Failsafe verification reportedBUILD SUCCESS.mvn -nsu failsafe:integration-test@integration-test failsafe:verify@verify -pl integration-test -am -PTableClusterIT -Pwith-integration-tests -Dit.test=IoTDBTableDDLHAIT -DfailIfNoTests=false -Dfailsafe.failIfNoSpecifiedTests=falsewith bounded JVM heaps.This PR has: