Repository navigation
[Test] Fix AlignedWritableMemChunkTest compilation error - #18859
Merged
Merged
Conversation
AlignedWritableMemChunk's constructor second parameter was changed from boolean isTableModel to EncryptParameter, and deserialize(DataInputStream, boolean) was reduced to deserialize(DataInputStream), but the test added in #18816 was not updated accordingly, breaking test compilation. Update the test to use the single-argument constructor and deserialize(DataInputStream).
Member
Author
JackieTien97
approved these changes
Oct 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18859 +/- ##
============================================
+ Coverage 45.93% 45.94% +0.01%
Complexity 712 712
============================================
Files 5502 5502
Lines 398935 398970 +35
Branches 52002 52015 +13
============================================
+ Hits 183237 183318 +81
+ Misses 215698 215652 -46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The datanode test compilation fails after the API change to
AlignedWritableMemChunk:Cause
AlignedWritableMemChunkTestwas added in #18816, whenAlignedWritableMemChunk's constructor took a secondboolean isTableModelparameter anddeserializetook a trailing boolean. A later change replaced the boolean withEncryptParameterand dropped the argument fromdeserialize(DataInputStream), but this test was not updated, so it no longer compiles.Fix
Drop the removed argument in the 4 constructor calls and in
deserialize(...), using the single-argument constructor (which defaults toEncryptUtils.getEncryptParameter()) anddeserialize(DataInputStream).