Repository navigation
[Test] Exclude mock initialization from pipe worker timeouts - #18886
Merged
Merged
Conversation
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PipeProcessorSubtaskWorkerTest.testOneHundredWaitingPipesDoNotWaitForWorkerPollingcan exhaust its 30-second timeout while a fresh Windows CI fork initializes Mockito/Byte Buddy, before any workers start. The failing CI job stops in Byte Buddy class loading and Mockito plugin initialization throughcreateRunnableSubtask:299.Initialize a
PipeProcessorSubtaskmock in@BeforeClass, before JUnit starts either worker-notification test's timer. Both tests keep their existing deadlines, including the 5-second admission wake-up assertion.Validation
mvn clean test -pl iotdb-core/datanode -am -Dtest=PipeProcessorSubtaskWorkerTest,PipeProcessorSubtaskExecutionGuardTest,PipeMemoryManagerTest -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false -Ddevelocity.off=true— 18 tests passed.mvn spotless:apply -pl iotdb-core/datanode— passed.createRunnableSubtask:299after 30.0 seconds; the fixed test passed, with 37.3 seconds total including class setup.This PR has: