Skip to content

[DO NOT MERGE] - #18906

Open
Caideyipi wants to merge 8 commits into
apache:masterfrom
Caideyipi:ci-daily-it-testutils-half-timeout
Open

Caideyipi wants to merge 8 commits into
apache:masterfrom
Caideyipi:ci-daily-it-testutils-half-timeout

Conversation

@Caideyipi

@Caideyipi Caideyipi commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Temporary Daily IT verification PR for #18905 and the accumulated Pipe fixes below. DO NOT MERGE.

A temporary pull_request trigger runs the existing Daily IT workflow with its consensus configurations and test selection retained: 34 matrix jobs, including 30 Pipe jobs.

The accumulated fixes cover:

  • Assertion flush timing: compare elapsed time and timeout using consistent units, with regression coverage.
  • Table LOAD schemas: register table schemas before sealing consensus LOAD files, including recovered tasks, so Pipe can enumerate their table data. Cover normal loads, recovery and null tags.
  • ConfigNode Pipe stop: check stop state before and after a blocked source.supply(), retain a fetched event for restart, and release it when dropped. Published separately in [Fix] Guard stopped Pipe polling and retain LOAD payloads until replicated #18913.
  • Credential identity and permission retries: resolve user IDs when explicit source or write-back sink credentials change. Retain TsFile table names and tree schema metadata until event resource release, so denied events can retry after SELECT is granted and later retries still check permissions. Published separately in [Pipe] Refresh credential user IDs and retain privilege metadata across retries #18914.

The permission retry fix addresses the reported IoTDBPipePermissionIT.testSourcePermission:231 timeout. Correct user-ID enforcement exposes an existing retry defect: clearing privilege metadata after the first check makes the next attempt fail with a tableNames null-pointer exception. Regression coverage checks repeated denial, successful retries, revocation and realtime tree permission checks.

Validation

  • The retry regression reproduces the original null-pointer exception before the fix.
  • PipeTsFileInsertionEventTest, PipeAuthenticationIdentityTest and ShowCreateTaskTest: 15 tests passed on this branch.
  • IoTDBPipePermissionIT#testSourcePermission: passed in 67 seconds with two HighPerformanceMode clusters (Ratis/Ratis/IoT, schema replication 3, data replication 2).
  • Spotless and git diff --check passed for the retry fix; the same changed files passed Checkstyle and DataNode Apache RAT on [Pipe] Refresh credential user IDs and retain privilege metadata across retries #18914.
  • Previous lifecycle validation: the original testLifeCycleWithHistoryDisabled IT passed with two ScalableSingleNodeMode clusters, all 8 related unit tests passed, and English/Chinese ConfigNode compilation and formatting checks passed.

Daily IT run for commit 496c51a7fdc is in progress; full matrix results are pending. This PR remains for temporary CI verification and must not be merged.

Register table schemas before sealing consensus LOAD files, including recovered tasks, so Pipe can enumerate their table data. Cover normal loads, recovery, and null tags with regression tests.
Treat the default IoTConsensus V1 WAL watermark as unconfirmed replication in both retention and the staged-directory cleaner. Keep immediate release for V2 and protocols without a V1 WAL. Cover commit payload readability, terminal task recovery, and cleanup before the first watermark.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant