GH-4230: Add GeoSPARQL 1.1 geometryN function - #4231
Open
edmondchuc wants to merge 1 commit into
Open
edmondchuc wants to merge 1 commit into
edmondchuc wants to merge 1 commit into
Conversation
edmondchuc
force-pushed
the
feat/geosparql/geometry-n-function
branch
3 times, most recently
from
September 17, 2026 05:58
26a3a9f to
5bbe8db
Compare
Add one-based member selection through geof:geometryN, retaining the selected member's datatype, SRS and layout. Accept only xsd:integer indexes, including integer-derived types such as xsd:short. Round-trip empty members in homogeneous WKT Multi geometries, including empty aggregates whose Z/M/ZM marker differs from the enclosing collection, and empty GML polygons whose CRS is 3D.
edmondchuc
force-pushed
the
feat/geosparql/geometry-n-function
branch
from
September 17, 2026 10:52
37b5b05 to
4a6c59c
Compare
Member
|
I see changes to the GML and WKT readers and writers. Is existing the test suite coverage (org/apache/jena/geosparql/implementation/parsers/) sufficient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #4230
Adds the GeoSPARQL 1.1
geof:geometryNfunction, also available throughGeometryWrapper.getGeometryN(int).The index is one-based and selects direct members without flattening nested collections. For example,
geof:geometryN("MULTIPOINT ((1 2), (3 4))"^^geo:wktLiteral, 2)returns
POINT (3 4).Selected members retain their source datatype, SRS, and coordinate layout. Indices must have datatype
xsd:integeror an integer-derived datatype. Invalid indices raise an expression error.This also prevents serialisation from silently dropping empty members and adds WKT reader support for empty members in Multi-geometries.
Depends on #4222 for the coordinate-sequence fixes needed to preserve Z/M values. All tests should pass once this branch is rebased after #4222 merges.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.